Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1855573002: Include quotes when printing out strings from beEqualTo (Closed)

Created:
4 years, 8 months ago by Raymond Toy
Modified:
4 years, 8 months ago
Reviewers:
hongchan
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include quotes when printing out strings from beEqualTo In Should().beEqualTo print out quotes if the expected value is a string. Expected results updated for this change; there are otherwise no changes to the tests themselves. BUG=591513 TEST=none Committed: https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb Cr-Commit-Position: refs/heads/master@{#388089}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use specified quotes #

Messages

Total messages: 11 (3 generated)
Raymond Toy
PTAL
4 years, 8 months ago (2016-04-01 21:16:56 UTC) #2
Raymond Toy
PTAL
4 years, 8 months ago (2016-04-13 15:26:29 UTC) #3
hongchan
https://codereview.chromium.org/1855573002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right): https://codereview.chromium.org/1855573002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js#newcode523 third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:523: } Can we use single quotes for the string ...
4 years, 8 months ago (2016-04-18 17:51:21 UTC) #4
Raymond Toy
https://codereview.chromium.org/1855573002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right): https://codereview.chromium.org/1855573002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js#newcode523 third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:523: } On 2016/04/18 at 17:51:21, hoch wrote: > Can ...
4 years, 8 months ago (2016-04-18 18:31:11 UTC) #5
hongchan
lgtm
4 years, 8 months ago (2016-04-18 20:49:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855573002/20001
4 years, 8 months ago (2016-04-18 20:54:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 00:09:29 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 00:10:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb
Cr-Commit-Position: refs/heads/master@{#388089}

Powered by Google App Engine
This is Rietveld 408576698