Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1855533002: PPC: [turbofan] Optimize loading 64-bit SMIs. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Optimize loading 64-bit SMIs. Especially when loading and untagging SMIs within code stubs, instances of the following pattern appear in the generated code: ld <dst>, <offset>(<base>) sradi <dst>,<dst>,32 This CL changes that code to: lwa <dst>, <SmiWordOffset(offset)>(<base>) R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/6ae6d3f8b70e05eb5dd0cdaff77b530486c08ad2 Cr-Commit-Position: refs/heads/master@{#35216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-01 18:19:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855533002/1
4 years, 8 months ago (2016-04-01 18:19:33 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 18:39:46 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-04-01 18:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855533002/1
4 years, 8 months ago (2016-04-01 19:05:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 19:07:08 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 19:08:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ae6d3f8b70e05eb5dd0cdaff77b530486c08ad2
Cr-Commit-Position: refs/heads/master@{#35216}

Powered by Google App Engine
This is Rietveld 408576698