net/socket/tcp_socket_win.cc - Issue 185553013: Standardize error reporting of IPEndPoint::ToSockAddr and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_socket_win.cc

Issue 185553013: Standardize error reporting of IPEndPoint::ToSockAddr and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Explain why we set errno to EADDRNOTAVAIL Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_socket_win.cc

===================================================================

--- net/socket/tcp_socket_win.cc (revision 259378)

+++ net/socket/tcp_socket_win.cc (working copy)

@@ -711,8 +711,9 @@

NOTREACHED();

if (closesocket(new_socket) < 0)

PLOG(ERROR) << "closesocket";

- net_log_.EndEventWithNetErrorCode(NetLog::TYPE_TCP_ACCEPT, ERR_FAILED);

- return ERR_FAILED;

+ int net_error = ERR_ADDRESS_INVALID;

+ net_log_.EndEventWithNetErrorCode(NetLog::TYPE_TCP_ACCEPT, net_error);

+ return net_error;

}

scoped_ptr<TCPSocketWin> tcp_socket(new TCPSocketWin(

net_log_.net_log(), net_log_.source()));

@@ -767,7 +768,7 @@

SockaddrStorage storage;

if (!peer_address_->ToSockAddr(storage.addr, &storage.addr_len))

- return ERR_INVALID_ARGUMENT;

+ return ERR_ADDRESS_INVALID;

if (!connect(socket_, storage.addr, storage.addr_len)) {

// Connected without waiting!

« no previous file with comments | « net/socket/tcp_socket_libevent.cc ('k') | net/udp/udp_socket_libevent.cc » ('j') | no next file with comments »