Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: net/udp/udp_socket_libevent.cc

Issue 185553013: Standardize error reporting of IPEndPoint::ToSockAddr and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/udp/udp_socket_libevent.cc
===================================================================
--- net/udp/udp_socket_libevent.cc (revision 254575)
+++ net/udp/udp_socket_libevent.cc (working copy)
@@ -128,7 +128,7 @@
return MapSystemError(errno);
scoped_ptr<IPEndPoint> address(new IPEndPoint());
if (!address->FromSockAddr(storage.addr, storage.addr_len))
- return ERR_FAILED;
+ return ERR_ADDRESS_INVALID;
remote_address_.reset(address.release());
}
@@ -148,7 +148,7 @@
return MapSystemError(errno);
scoped_ptr<IPEndPoint> address(new IPEndPoint());
if (!address->FromSockAddr(storage.addr, storage.addr_len))
- return ERR_FAILED;
+ return ERR_ADDRESS_INVALID;
local_address_.reset(address.release());
net_log_.AddEvent(NetLog::TYPE_UDP_LOCAL_ADDRESS,
CreateNetLogUDPConnectCallback(local_address_.get()));
@@ -476,7 +476,7 @@
if (bytes_transferred >= 0) {
result = bytes_transferred;
if (address && !address->FromSockAddr(storage.addr, storage.addr_len))
- result = ERR_FAILED;
+ result = ERR_ADDRESS_INVALID;
} else {
result = MapSystemError(errno);
}
@@ -494,7 +494,7 @@
storage.addr_len = 0;
} else {
if (!address->ToSockAddr(storage.addr, &storage.addr_len)) {
- int result = ERR_FAILED;
+ int result = ERR_ADDRESS_INVALID;
LogWrite(result, NULL, NULL);
return result;
}

Powered by Google App Engine
This is Rietveld 408576698