Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Unified Diff: Source/devtools/front_end/TimelineView.js

Issue 185553006: DevTools: follow up to r168290, fix presentation model properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineView.js
diff --git a/Source/devtools/front_end/TimelineView.js b/Source/devtools/front_end/TimelineView.js
index 093994f4c0ef31d7cf6d68c8bb44bd9b28c94541..78e188746eb6703331508a69132d5b2f29663dc3 100644
--- a/Source/devtools/front_end/TimelineView.js
+++ b/Source/devtools/front_end/TimelineView.js
@@ -504,7 +504,7 @@ WebInspector.TimelineView.prototype = {
var record = recordsInWindow[i];
if (i < startIndex) {
- var lastChildIndex = i + record.visibleChildrenCount;
+ var lastChildIndex = i + record.visibleChildrenCount();
if (lastChildIndex >= startIndex && lastChildIndex < endIndex) {
var expandElement = new WebInspector.TimelineExpandableElement(this._expandElements);
var positions = this._calculator.computeBarGraphWindowPosition(record);
@@ -1231,12 +1231,12 @@ WebInspector.TimelineExpandableElement.prototype = {
_update: function(record, index, left, width)
{
const rowHeight = WebInspector.TimelinePanel.rowHeight;
- if (record.visibleChildrenCount || record.expandable) {
+ if (record.visibleChildrenCount() || record.expandable()) {
this._element.style.top = index * rowHeight + "px";
this._element.style.left = left + "px";
this._element.style.width = Math.max(12, width + 25) + "px";
if (!record.collapsed()) {
- this._element.style.height = (record.visibleChildrenCount + 1) * rowHeight + "px";
+ this._element.style.height = (record.visibleChildrenCount() + 1) * rowHeight + "px";
this._element.classList.add("timeline-expandable-expanded");
this._element.classList.remove("timeline-expandable-collapsed");
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698