Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: tools/gn/ninja_create_bundle_target_writer.cc

Issue 1855523003: [GN] Fix create_bundle to respect "data_deps" dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_create_bundle_target_writer.cc
diff --git a/tools/gn/ninja_create_bundle_target_writer.cc b/tools/gn/ninja_create_bundle_target_writer.cc
index b92001d6089a9ff871bfc5d6df6efbf817311936..8fd2ab92afaaaa26955b0fadab312f57f3cc66a9 100644
--- a/tools/gn/ninja_create_bundle_target_writer.cc
+++ b/tools/gn/ninja_create_bundle_target_writer.cc
@@ -111,5 +111,10 @@ void NinjaCreateBundleTargetWriter::Run() {
}
out_ << std::endl;
- WriteStampForTarget(output_files, std::vector<OutputFile>());
+
+ std::vector<OutputFile> order_only_deps;
+ for (const auto& pair : target_->data_deps()) {
brettw 2016/04/04 23:11:56 No {}
sdefresne 2016/04/05 23:04:13 Done.
+ order_only_deps.push_back(pair.ptr->dependency_output_file());
+ }
+ WriteStampForTarget(output_files, order_only_deps);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698