[GN] Fix create_bundle to respect "data_deps" dependencies.

[GN] Fix create_bundle to respect "data_deps" dependencies.

Add "data_deps" output dependency files as order only dependencies of
"create_bundle" target to fix the issue that "data_deps" are not build.

BUG=599203
Committed: https://crrev.com/f8bb64b067eb0e61773b87c86fdda45f53e47498
Cr-Commit-Position: refs/heads/master@{#385325}

[sdefresne, 2016-04-01 18:19:24]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-04-01 18:19:25]

Please take a look.

[sdefresne, 2016-04-04 21:06:31]

Ping?

[brettw, 2016-04-04 23:11:57]

LGTM. Sorry, I was out at the end of last week.

https://codereview.chromium.org/1855523003/diff/1/tools/gn/ninja_create_bundl...
File tools/gn/ninja_create_bundle_target_writer.cc (right):

https://codereview.chromium.org/1855523003/diff/1/tools/gn/ninja_create_bundl...
tools/gn/ninja_create_bundle_target_writer.cc:116: for (const auto& pair :
target_->data_deps()) {
No {}

[sdefresne, 2016-04-05 23:02:44]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-04-05 23:02:45]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1855523003/#ps20001
(title: "Remove {}")

[commit-bot: I haz the power, 2016-04-05 23:02:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855523003/20001

[sdefresne, 2016-04-05 23:04:13]

Thank you for the review.

https://codereview.chromium.org/1855523003/diff/1/tools/gn/ninja_create_bundl...
File tools/gn/ninja_create_bundle_target_writer.cc (right):

https://codereview.chromium.org/1855523003/diff/1/tools/gn/ninja_create_bundl...
tools/gn/ninja_create_bundle_target_writer.cc:116: for (const auto& pair :
target_->data_deps()) {
On 2016/04/04 at 23:11:56, brettw wrote:
> No {}

Done.

[commit-bot: I haz the power, 2016-04-05 23:38:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 23:39:39]

Description was changed from

==========
[GN] Fix create_bundle to respect "data_deps" dependencies.

Add "data_deps" output dependency files as order only dependencies of
"create_bundle" target to fix the issue that "data_deps" are not build.

BUG=599203
==========

to

==========
[GN] Fix create_bundle to respect "data_deps" dependencies.

Add "data_deps" output dependency files as order only dependencies of
"create_bundle" target to fix the issue that "data_deps" are not build.

BUG=599203

Committed: https://crrev.com/f8bb64b067eb0e61773b87c86fdda45f53e47498
Cr-Commit-Position: refs/heads/master@{#385325}
==========

[commit-bot: I haz the power, 2016-04-05 23:39:40]

Patchset 2 (id:??) landed as
https://crrev.com/f8bb64b067eb0e61773b87c86fdda45f53e47498
Cr-Commit-Position: refs/heads/master@{#385325}