third_party/WebKit/Source/core/input/PointerEventManager.h - Issue 1855513002: Consider isPrimary and pointerType when preventing compat mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.h

Issue 1855513002: Consider isPrimary and pointerType when preventing compat mouse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/event_sender.cc ('K') | « third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/multi-pointer-preventdefault-expected.txt ('k') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('j') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/PointerEventManager.h

diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.h b/third_party/WebKit/Source/core/input/PointerEventManager.h

index deebe07536a58eca3c31f71960ca4da77e6bf262..d3b1a3435d2ba36c3caa34d5b84ec90e1b2938f3 100644

--- a/third_party/WebKit/Source/core/input/PointerEventManager.h

+++ b/third_party/WebKit/Source/core/input/PointerEventManager.h

@@ -132,7 +132,7 @@ private:

// Prevents firing mousedown, mousemove & mouseup in-between a canceled pointerdown and next pointerup/pointercancel.

// See "PREVENT MOUSE EVENT flag" in the spec:

// https://w3c.github.io/pointerevents/#compatibility-mapping-with-mouse-events

- bool m_preventMouseEventForPointerTypeMouse;

+ bool m_preventMouseEventForPointerType[static_cast<int>(WebPointerProperties::PointerType::LastEntry) + 1];

dtapuska 2016/04/05 19:21:25 Personally I'd cast to a size_t

Navid Zolghadr 2016/04/05 20:17:25 Done.

// Note that this map keeps track of node under pointer with id=1 as well

// which might be different than m_nodeUnderMouse in EventHandler. That one