Consider isPrimary and pointerType when preventing compat mouse

components/test_runner/event_sender.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/event_sender.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 40 matching lines @@
 using blink::WebString;
 using blink::WebTouchEvent;
 using blink::WebTouchPoint;
 using blink::WebVector;
 using blink::WebView;
 
 namespace test_runner {
 
 namespace {
 
+const int kMousePointerId = -1;
+const char* kPointerTypeStringUnknown = "";
+const char* kPointerTypeStringMouse = "mouse";
+const char* kPointerTypeStringPen = "pen";
+const char* kPointerTypeStringTouch = "touch";
+
+bool getPointerType(gin::Arguments* args,
+                    blink::WebPointerProperties::PointerType &t,

[dtapuska, 2016/04/07 02:35:41]

Should be PointerType& t. Both styles are allowed in the style guide; but you
need to be consistent in the file. Since the convention in this file and most;
the * and reference is with the type followed by a space.

But really you should have a better name than t; perhaps type?

Output arguments must always be last according to the style guide to. Which
won't allow you to use the default parameter. But you can easily define a
getPointerType with two args and call the 3 arg one.

Also need a bit of docs regarding that |t| is an output parameter.

[Navid Zolghadr, 2016/04/08 17:38:44]

Done. I got rid of the default value and in that single place that needed false
I passed the parameter.

+                    bool isOnlyMouseAndPenAllowed = false) {
+  if (!args->PeekNext().IsEmpty()) {
+    std::string pointer_type_string;
+    if (!args->GetNext(&pointer_type_string)) {
+      args->ThrowError();
+      return false;
+    }
+    if (pointer_type_string == kPointerTypeStringUnknown) {
+      if (isOnlyMouseAndPenAllowed) {
+        args->ThrowError();
+        return false;
+      }
+      t = WebMouseEvent::PointerType::Unknown;
+    } else if (pointer_type_string == kPointerTypeStringMouse) {
+      t = WebMouseEvent::PointerType::Mouse;
+    } else if (pointer_type_string == kPointerTypeStringPen) {
+      t = WebMouseEvent::PointerType::Pen;
+    } else if (pointer_type_string == kPointerTypeStringTouch) {
+      if (isOnlyMouseAndPenAllowed) {
+        args->ThrowError();
+        return false;
+      }
+      t = WebMouseEvent::PointerType::Touch;
+    } else {
+      args->ThrowError();
+      return false;
+    }
+  }
+  return true;

[mustaq, 2016/04/07 19:30:02]

Nit: Please avoid three levels of nested |if|s, by using short-cut returns: must
simpler to follow and less error-prone.

[Navid Zolghadr, 2016/04/08 17:38:44]

Done.

+}
+
+bool getMousePenPointerTypeAndId(gin::Arguments* args,
+                    blink::WebPointerProperties::PointerType &t,

[dtapuska, 2016/04/07 02:35:41]

ditto; comments as above.

[Navid Zolghadr, 2016/04/08 17:38:44]

Done.

+                    int &id) {
+  t = blink::WebPointerProperties::PointerType::Mouse;
+  id = kMousePointerId;
+  // Only allow pen or mouse through this API.
+  if (!getPointerType(args, t, true))
+    return false;
+  if (!args->PeekNext().IsEmpty()) {
+    if (!args->GetNext(&id)) {
+      args->ThrowError();
+      return false;
+    }
+    if (t != blink::WebPointerProperties::PointerType::Mouse
+        && id == kMousePointerId) {
+      args->ThrowError();
+      return false;
+    }
+  } else if (t == blink::WebPointerProperties::PointerType::Pen) {
+    id = 1; // A default value for the id of the pen
+  }
+  return true;
+}
+
 WebMouseEvent::Button GetButtonTypeFromButtonNumber(int button_code) {
   switch (button_code) {
     case -1:
       return WebMouseEvent::ButtonNone;
     case 0:
       return WebMouseEvent::ButtonLeft;
     case 1:
       return WebMouseEvent::ButtonMiddle;
     case 2:
       return WebMouseEvent::ButtonRight;
@@ skipping 25 matching lines @@
       | (buttons & kButtonsInModifiers);
 }
 
 void InitMouseEvent(WebInputEvent::Type t,
                     WebMouseEvent::Button b,
                     int current_buttons,
                     const WebPoint& pos,
                     double time_stamp,
                     int click_count,
                     int modifiers,
+                    blink::WebPointerProperties::PointerType pointerType,
+                    int pointerId,
                     WebMouseEvent* e) {
   e->type = t;
   e->button = b;
   e->modifiers = modifiersWithButtons(modifiers, current_buttons);
   e->x = pos.x;
   e->y = pos.y;
   e->globalX = pos.x;
   e->globalY = pos.y;
-  e->pointerType = blink::WebPointerProperties::PointerType::Mouse;
+  e->pointerType = pointerType;
+  if (pointerType != blink::WebPointerProperties::PointerType::Mouse)

[mustaq, 2016/04/07 19:30:02]

I think it's better to allow any ids here. This would keep the gate open to
check, e.g., what would happen if Blink gets a mouse event with id=123.

[Navid Zolghadr, 2016/04/08 17:38:44]

Sure. Then here for mouse by default we are sending -1 instead of previous 0
which I believe shouldn't break the existing tests.

+    e->id = pointerId;
   e->timeStampSeconds = time_stamp;
   e->clickCount = click_count;
 }
 
 void InitGestureEventFromMouseWheel(WebInputEvent::Type type,
                                     double time_stamp,
                                     const WebMouseWheelEvent& wheel_event,
                                     WebGestureEvent* gesture_event) {
   gesture_event->type = type;
   gesture_event->sourceDevice = blink::WebGestureDeviceTouchpad;
@@ skipping 323 matching lines @@
     }
   } else {
     *units = WebGestureEvent::PrecisePixels;
     return true;
   }
 }
 
 const char* kSourceDeviceStringTouchpad = "touchpad";
 const char* kSourceDeviceStringTouchscreen = "touchscreen";
 
-const char* kPointerTypeStringUnknown = "";
-const char* kPointerTypeStringMouse = "mouse";
-const char* kPointerTypeStringPen = "pen";
-const char* kPointerTypeStringTouch = "touch";
-
 }  // namespace
 
 class EventSenderBindings : public gin::Wrappable<EventSenderBindings> {
  public:
   static gin::WrapperInfo kWrapperInfo;
 
   static void Install(base::WeakPtr<EventSender> sender,
                       blink::WebFrame* frame);
 
  private:
@@ skipping 498 matching lines @@
   sender_->ScheduleAsynchronousKeyDown(code_str, modifiers,
                                        static_cast<KeyLocationCode>(location));
 }
 
 void EventSenderBindings::MouseDown(gin::Arguments* args) {
   if (!sender_)
     return;
 
   int button_number = 0;
   int modifiers = 0;
+  blink::WebPointerProperties::PointerType pointerType =
+      blink::WebPointerProperties::PointerType::Mouse;
+  int pointerId = 0;
   if (!args->PeekNext().IsEmpty()) {
-    args->GetNext(&button_number);
-    if (!args->PeekNext().IsEmpty())
+    if (!args->GetNext(&button_number)) {
+      args->ThrowError();
+      return;
+    }
+    if (!args->PeekNext().IsEmpty()) {
       modifiers = GetKeyModifiersFromV8(args->isolate(), args->PeekNext());
+      args->Skip();
+    }
   }
-  sender_->MouseDown(button_number, modifiers);
+
+  if (!getMousePenPointerTypeAndId(args, pointerType, pointerId))
+    return;
+
+  sender_->MouseDown(button_number, modifiers, pointerType, pointerId);
 }
 
 void EventSenderBindings::MouseUp(gin::Arguments* args) {
   if (!sender_)
     return;
 
   int button_number = 0;
   int modifiers = 0;
+  blink::WebPointerProperties::PointerType pointerType =
+      blink::WebPointerProperties::PointerType::Mouse;
+  int pointerId = 0;
   if (!args->PeekNext().IsEmpty()) {
-    args->GetNext(&button_number);
-    if (!args->PeekNext().IsEmpty())
+    if (!args->GetNext(&button_number)) {
+      args->ThrowError();
+      return;
+    }
+    if (!args->PeekNext().IsEmpty()) {
       modifiers = GetKeyModifiersFromV8(args->isolate(), args->PeekNext());
+      args->Skip();
+    }
   }
-  sender_->MouseUp(button_number, modifiers);
+
+  if (!getMousePenPointerTypeAndId(args, pointerType, pointerId))
+    return;
+
+  sender_->MouseUp(button_number, modifiers, pointerType, pointerId);
 }
 
 void EventSenderBindings::SetMouseButtonState(gin::Arguments* args) {
   if (!sender_)
     return;
 
   int button_number;
   if (!args->GetNext(&button_number)) {
     args->ThrowError();
     return;
@@ skipping 132 matching lines @@
 }
 
 void EventSenderBindings::SetWmSysDeadChar(int sys_dead_char) {
   if (sender_)
     sender_->set_wm_sys_dead_char(sys_dead_char);
 }
 #endif
 
 // EventSender -----------------------------------------------------------------
 
-WebMouseEvent::Button EventSender::pressed_button_ = WebMouseEvent::ButtonNone;
-int EventSender::current_buttons_ = 0;
-int EventSender::modifiers_ = 0;
-
-WebPoint EventSender::last_mouse_pos_;
-
 WebMouseEvent::Button EventSender::last_button_type_ =
     WebMouseEvent::ButtonNone;
 
 EventSender::SavedEvent::SavedEvent()
     : type(TYPE_UNSPECIFIED),
       button_type(WebMouseEvent::ButtonNone),
       milliseconds(0),
       modifiers(0) {}
 
 EventSender::EventSender(TestInterfaces* interfaces)
@@ skipping 25 matching lines @@
       weak_factory_(this) {
 }
 
 EventSender::~EventSender() {}
 
 void EventSender::Reset() {
   DCHECK(current_drag_data_.isNull());
   current_drag_data_.reset();
   current_drag_effect_ = blink::WebDragOperationNone;
   current_drag_effects_allowed_ = blink::WebDragOperationNone;
-  if (view_ && pressed_button_ != WebMouseEvent::ButtonNone)
+  if (view_ && current_pointer_state_[kMousePointerId].pressed_button_
+      != WebMouseEvent::ButtonNone)
     view_->mouseCaptureLost();
-  pressed_button_ = WebMouseEvent::ButtonNone;
-  current_buttons_ = 0;
-  modifiers_ = 0;
+  current_pointer_state_.clear();
   is_drag_mode_ = true;
   force_layout_on_events_ = true;
 
 #if defined(OS_WIN)
   wm_key_down_ = WM_KEYDOWN;
   wm_key_up_ = WM_KEYUP;
   wm_char_ = WM_CHAR;
   wm_dead_char_ = WM_DEADCHAR;
   wm_sys_key_down_ = WM_SYSKEYDOWN;
   wm_sys_key_up_ = WM_SYSKEYUP;
   wm_sys_char_ = WM_SYSCHAR;
   wm_sys_dead_char_ = WM_SYSDEADCHAR;
 #endif
 
-  last_mouse_pos_ = WebPoint(0, 0);
   last_click_time_sec_ = 0;
   last_click_pos_ = WebPoint(0, 0);
   last_button_type_ = WebMouseEvent::ButtonNone;
   touch_points_.clear();
   last_context_menu_data_.reset();
   task_list_.RevokeAll();
   current_gesture_location_ = WebPoint(0, 0);
   mouse_event_queue_.clear();
 
   time_offset_ms_ = 0;
@@ skipping 17 matching lines @@
 }
 
 void EventSender::SetContextMenuData(const WebContextMenuData& data) {
   last_context_menu_data_.reset(new WebContextMenuData(data));
 }
 
 void EventSender::DoDragDrop(const WebDragData& drag_data,
                               WebDragOperationsMask mask) {
   WebMouseEvent event;
   InitMouseEvent(WebInputEvent::MouseDown,
-                 pressed_button_,
-                 current_buttons_,
-                 last_mouse_pos_,
+                 current_pointer_state_[kMousePointerId].pressed_button_,
+                 current_pointer_state_[kMousePointerId].current_buttons_,
+                 current_pointer_state_[kMousePointerId].last_pos_,
                  GetCurrentEventTimeSec(),
                  click_count_,
-                 modifiers_,
+                 current_pointer_state_[kMousePointerId].modifiers_,
+                 blink::WebPointerProperties::PointerType::Mouse,
+                 0,
                  &event);
   WebPoint client_point(event.x, event.y);
   WebPoint screen_point(event.globalX, event.globalY);
   current_drag_data_ = drag_data;
   current_drag_effects_allowed_ = mask;
   current_drag_effect_ = view_->dragTargetDragEnter(
       drag_data,
       client_point,
       screen_point,
       current_drag_effects_allowed_,
-      modifiersWithButtons(modifiers_, current_buttons_));
+      modifiersWithButtons(current_pointer_state_[kMousePointerId].modifiers_,
+          current_pointer_state_[kMousePointerId].current_buttons_));
 
   // Finish processing events.
   ReplaySavedEvents();
 }
 
-void EventSender::MouseDown(int button_number, int modifiers) {
+void EventSender::MouseDown(int button_number, int modifiers,
+    blink::WebPointerProperties::PointerType pointerType, int pointerId) {
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
 
   DCHECK_NE(-1, button_number);
 
   WebMouseEvent::Button button_type =
       GetButtonTypeFromButtonNumber(button_number);
 
-  UpdateClickCountForButton(button_type);
+  WebMouseEvent event;
+  int click_count = 0;
+  current_pointer_state_[pointerId].pressed_button_ = button_type;
+  current_pointer_state_[pointerId].current_buttons_ |=
+    GetWebMouseEventModifierForButton(button_type);
+  current_pointer_state_[pointerId].modifiers_ = modifiers;
 
-  pressed_button_ = button_type;
-  current_buttons_ |= GetWebMouseEventModifierForButton(pressed_button_);
-  modifiers_ = modifiers;
+  if (pointerType == blink::WebPointerProperties::PointerType::Mouse) {
+    UpdateClickCountForButton(button_type);
+    click_count = click_count_;
+  }
+  InitMouseEvent(WebInputEvent::MouseDown,
+                 current_pointer_state_[pointerId].pressed_button_,
+                 current_pointer_state_[pointerId].current_buttons_,
+                 current_pointer_state_[pointerId].last_pos_,
+                 GetCurrentEventTimeSec(),
+                 click_count,
+                 current_pointer_state_[pointerId].modifiers_,
+                 pointerType,
+                 pointerId,

[dtapuska, 2016/04/07 02:35:41]

Do we need to be concerned we are passing -1 potentially in here for mouse?

[Navid Zolghadr, 2016/04/07 03:08:04]

There is a check in InitMouseEvent which ignores the pointerId when the
pointerType is mouse. So basically this -1 is only an event_sender thing and
never gets exposed to the Blink.

[mustaq, 2016/04/07 19:30:02]

I am fine with allowing unexpected values here, to make event_sender more
flexible. We need the ability to test Blink with unusual values, and making the
event sender more "intelligent" about the perfect input is a bar to this. E.g.
we allow setting the |movedBeyondSlopRegion| bit in a TouchEvent even when the
touchpoint hasn't moved much. This isolates testing the dependence on this bits
w/o being worrying about a slop-region definition.

[Navid Zolghadr, 2016/04/08 17:38:44]

I removed the check in InitMouseEvent to set any id.

+                 &event);
 
-  WebMouseEvent event;
-  InitMouseEvent(WebInputEvent::MouseDown,
-                 pressed_button_,
-                 current_buttons_,
-                 last_mouse_pos_,
-                 GetCurrentEventTimeSec(),
-                 click_count_,
-                 modifiers_,
-                 &event);
   HandleInputEventOnViewOrPopup(event);
 }
 
-void EventSender::MouseUp(int button_number, int modifiers) {
+void EventSender::MouseUp(int button_number, int modifiers,
+    blink::WebPointerProperties::PointerType pointerType, int pointerId) {
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
 
   DCHECK_NE(-1, button_number);
 
   WebMouseEvent::Button button_type =
       GetButtonTypeFromButtonNumber(button_number);
 
-  if (is_drag_mode_ && !replaying_saved_events_) {
-    SavedEvent saved_event;
-    saved_event.type = SavedEvent::TYPE_MOUSE_UP;
-    saved_event.button_type = button_type;
-    saved_event.modifiers = modifiers;
-    mouse_event_queue_.push_back(saved_event);
-    ReplaySavedEvents();
+  if (pointerType == blink::WebPointerProperties::PointerType::Mouse) {
+    if (is_drag_mode_ && !replaying_saved_events_) {
+      SavedEvent saved_event;
+      saved_event.type = SavedEvent::TYPE_MOUSE_UP;
+      saved_event.button_type = button_type;
+      saved_event.modifiers = modifiers;
+      mouse_event_queue_.push_back(saved_event);
+      ReplaySavedEvents();
+    } else {
+        current_pointer_state_[kMousePointerId].current_buttons_ &=
+            ~GetWebMouseEventModifierForButton(button_type);
+        current_pointer_state_[kMousePointerId].pressed_button_ =
+            WebMouseEvent::ButtonNone;
+
+      WebMouseEvent event;
+      InitMouseEvent(WebInputEvent::MouseUp,
+                     button_type,
+                     current_pointer_state_[kMousePointerId].current_buttons_,
+                     current_pointer_state_[kMousePointerId].last_pos_,
+                     GetCurrentEventTimeSec(),
+                     click_count_,
+                     modifiers,
+                     pointerType,
+                     0,

[dtapuska, 2016/04/07 02:35:41]

Whereas we pass 0 in here for mouseup?

This code looks very duplicated to the code below except for the 0 passed in and
the DoMouseUp(...) vs HandleInputEventOnViewOrPopup.. Could we collapse them
into the same codepath? Perhaps not; just a thought.

[Navid Zolghadr, 2016/04/07 03:08:04]

I was thinking of doing this similar to what I did for mouseDown to share the
code. The problem was that there was this if else for the flow of existing mouse
(I guess it is dragging of some sort). I could have jammed the if conditions
together and somehow use one code path for firing of the event. But I thought
that might be more confusing than just duplicating this code. Which one do you
think i s better? This one or anding those conditions altogether and also add
another if at the end for the DoMouseUp vs HandleInputEventOnViewOrPopup?

[dtapuska, 2016/04/07 03:15:24]

Personally; I'd probably look at pulling the HandleInputEventOnViewOrPopup out
of the DoMouseXX method and then have a code path that was similar for the two
but do some post processing after the dispatch to call DoMouseXX..

[mustaq, 2016/04/07 19:30:02]

I agree, the two DoMouse* methods are doing local post-processing/bookkeeping
for drag right after handleInputEvent call (and MouseDown doesn't evnet have a
DoMouseDown). Please pull the handle... call out, then rename DoMouse* to
DoDragAfterMouse*.

[Navid Zolghadr, 2016/04/08 17:38:44]

Done.

+                     &event);
+      DoMouseUp(event);
+    }
   } else {
-    current_buttons_ &= ~GetWebMouseEventModifierForButton(button_type);
-    pressed_button_ = WebMouseEvent::ButtonNone;
+      current_pointer_state_[pointerId].current_buttons_ &=
+          ~GetWebMouseEventModifierForButton(button_type);
+      current_pointer_state_[pointerId].pressed_button_ =
+          WebMouseEvent::ButtonNone;
 
-    WebMouseEvent event;
-    InitMouseEvent(WebInputEvent::MouseUp,
-                   button_type,
-                   current_buttons_,
-                   last_mouse_pos_,
-                   GetCurrentEventTimeSec(),
-                   click_count_,
-                   modifiers,
-                   &event);
-    DoMouseUp(event);
+      WebMouseEvent event;
+      InitMouseEvent(WebInputEvent::MouseUp,
+                     button_type,
+                     current_pointer_state_[pointerId].current_buttons_,
+                     current_pointer_state_[pointerId].last_pos_,
+                     GetCurrentEventTimeSec(),
+                     0,
+                     modifiers,
+                     pointerType,
+                     pointerId,
+                     &event);
+      HandleInputEventOnViewOrPopup(event);
   }
 }
 
 void EventSender::SetMouseButtonState(int button_number, int modifiers) {
-  pressed_button_ = GetButtonTypeFromButtonNumber(button_number);
-  current_buttons_ = (modifiers == -1) ?
-      GetWebMouseEventModifierForButton(pressed_button_) :
+  current_pointer_state_[kMousePointerId].pressed_button_ =
+      GetButtonTypeFromButtonNumber(button_number);
+  current_pointer_state_[kMousePointerId].current_buttons_ = (modifiers == -1) ?
+      GetWebMouseEventModifierForButton(
+          current_pointer_state_[kMousePointerId].pressed_button_) :
       modifiers & kButtonsInModifiers;
 }
 
 void EventSender::KeyDown(const std::string& code_str,
                           int modifiers,
                           KeyLocationCode location) {
   // FIXME: I'm not exactly sure how we should convert the string to a key
   // event. This seems to work in the cases I tested.
   // FIXME: Should we also generate a KEY_UP?
 
@@ skipping 180 matching lines @@
   // We just simulate the same behavior here.
   std::string edit_command;
   if (GetEditCommand(event_down, &edit_command))
     delegate_->SetEditCommand(edit_command, "");
 
   HandleInputEventOnViewOrPopup(event_down);
 
   if (code == ui::VKEY_ESCAPE && !current_drag_data_.isNull()) {
     WebMouseEvent event;
     InitMouseEvent(WebInputEvent::MouseDown,
-                   pressed_button_,
-                   current_buttons_,
-                   last_mouse_pos_,
+                   current_pointer_state_[kMousePointerId].pressed_button_,
+                   current_pointer_state_[kMousePointerId].current_buttons_,
+                   current_pointer_state_[kMousePointerId].last_pos_,
                    GetCurrentEventTimeSec(),
                    click_count_,
                    0,
+                   blink::WebPointerProperties::PointerType::Mouse,
+                   0,
                    &event);
     FinishDragAndDrop(event, blink::WebDragOperationNone);
   }
 
   delegate_->ClearEditCommand();
 
   if (generate_char) {
     WebKeyboardEvent event_char = event_up;
     event_char.type = WebInputEvent::Char;
     // keyIdentifier is an empty string, unless the Enter key was pressed.
@@ skipping 24 matching lines @@
   // be requested after following mouse events.
   last_context_menu_data_.reset();
 
   // Generate right mouse down and up.
   WebMouseEvent event;
   // This is a hack to work around only allowing a single pressed button since
   // we want to test the case where both the left and right mouse buttons are
   // pressed.
   // TODO(mustaq): This hack seems unused here! But do we need this hack at all
   //   after adding current_buttons_.
-  if (pressed_button_ == WebMouseEvent::ButtonNone) {
-    pressed_button_ = WebMouseEvent::ButtonRight;
-    current_buttons_ |= GetWebMouseEventModifierForButton(pressed_button_);
+  if (current_pointer_state_[kMousePointerId].pressed_button_
+      == WebMouseEvent::ButtonNone) {
+    current_pointer_state_[kMousePointerId].pressed_button_ =
+        WebMouseEvent::ButtonRight;
+    current_pointer_state_[kMousePointerId].current_buttons_ |=
+        GetWebMouseEventModifierForButton(
+        current_pointer_state_[kMousePointerId].pressed_button_);
   }
   InitMouseEvent(WebInputEvent::MouseDown,
                  WebMouseEvent::ButtonRight,
-                 current_buttons_,
-                 last_mouse_pos_,
+                 current_pointer_state_[kMousePointerId].current_buttons_,
+                 current_pointer_state_[kMousePointerId].last_pos_,
                  GetCurrentEventTimeSec(),
                  click_count_,
                  0,
+                 blink::WebPointerProperties::PointerType::Mouse,
+                 0,
                  &event);
   HandleInputEventOnViewOrPopup(event);
 
 #if defined(OS_WIN)
-  current_buttons_ &=
+  current_pointer_state_[kMousePointerId].current_buttons_ &=
       ~GetWebMouseEventModifierForButton(WebMouseEvent::ButtonRight);
-  pressed_button_ = WebMouseEvent::ButtonNone;
+  current_pointer_state_[kMousePointerId].pressed_button_ =
+      WebMouseEvent::ButtonNone;
 
   InitMouseEvent(WebInputEvent::MouseUp,
                  WebMouseEvent::ButtonRight,
-                 current_buttons_,
-                 last_mouse_pos_,
+                 current_pointer_state_[kMousePointerId].current_buttons_,
+                 current_pointer_state_[kMousePointerId].last_pos_,
                  GetCurrentEventTimeSec(),
                  click_count_,
                  0,
+                 blink::WebPointerProperties::PointerType::Mouse,
+                 0,
                  &event);
   HandleInputEventOnViewOrPopup(event);
 #endif
 
   std::vector<std::string> menu_items =
       MakeMenuItemStringsFor(last_context_menu_data_.get(), delegate_);
   last_context_menu_data_.reset();
   return menu_items;
 }
 
@@ skipping 186 matching lines @@
 
 void EventSender::TouchCancel() {
   SendCurrentTouchEvent(WebInputEvent::TouchCancel, false);
 }
 
 void EventSender::TouchEnd() {
   SendCurrentTouchEvent(WebInputEvent::TouchEnd, false);
 }
 
 void EventSender::LeapForward(int milliseconds) {
-  if (is_drag_mode_ && pressed_button_ == WebMouseEvent::ButtonLeft &&
+  if (is_drag_mode_ && current_pointer_state_[kMousePointerId].pressed_button_
+      == WebMouseEvent::ButtonLeft &&
       !replaying_saved_events_) {
     SavedEvent saved_event;
     saved_event.type = SavedEvent::TYPE_LEAP_FORWARD;
     saved_event.milliseconds = milliseconds;
     mouse_event_queue_.push_back(saved_event);
   } else {
     DoLeapForward(milliseconds);
   }
 }
 
@@ skipping 16 matching lines @@
     item.filenameData = delegate_->GetAbsoluteWebStringFromUTF8Path(files[i]);
     current_drag_data_.addItem(item);
     absolute_filenames[i] = item.filenameData;
   }
   current_drag_data_.setFilesystemId(
       delegate_->RegisterIsolatedFileSystem(absolute_filenames));
   current_drag_effects_allowed_ = blink::WebDragOperationCopy;
 
   // Provide a drag source.
   view_->dragTargetDragEnter(current_drag_data_,
-                             last_mouse_pos_,
-                             last_mouse_pos_,
+                             current_pointer_state_[kMousePointerId].last_pos_,
+                             current_pointer_state_[kMousePointerId].last_pos_,
                              current_drag_effects_allowed_,
                              0);
   // |is_drag_mode_| saves events and then replays them later. We don't
   // need/want that.
   is_drag_mode_ = false;
 
   // Make the rest of eventSender think a drag is in progress.
-  pressed_button_ = WebMouseEvent::ButtonLeft;
-  current_buttons_ |= GetWebMouseEventModifierForButton(pressed_button_);
+  current_pointer_state_[kMousePointerId].pressed_button_ =
+      WebMouseEvent::ButtonLeft;
+  current_pointer_state_[kMousePointerId].current_buttons_ |=
+      GetWebMouseEventModifierForButton(
+      current_pointer_state_[kMousePointerId].pressed_button_);
 }
 
 void EventSender::AddTouchPoint(float x, float y, gin::Arguments* args) {
   WebTouchPoint touch_point;
   touch_point.pointerType = WebPointerProperties::PointerType::Touch;
   touch_point.state = WebTouchPoint::StatePressed;
   touch_point.position = WebFloatPoint(x, y);
   touch_point.screenPosition = touch_point.position;
 
   int highest_id = -1;
@@ skipping 79 matching lines @@
     SendGesturesForMouseWheelEvent(wheel_event);
   }
 }
 
 void EventSender::MouseMoveTo(gin::Arguments* args) {
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
 
   double x;
   double y;
+  blink::WebPointerProperties::PointerType pointerType =
+      blink::WebPointerProperties::PointerType::Mouse;
+  int pointerId = 0;
   if (!args->GetNext(&x) || !args->GetNext(&y)) {
     args->ThrowError();
     return;
   }
   WebPoint mouse_pos(static_cast<int>(x), static_cast<int>(y));
 
   int modifiers = 0;
-  if (!args->PeekNext().IsEmpty())
+  if (!args->PeekNext().IsEmpty()) {
     modifiers = GetKeyModifiersFromV8(args->isolate(), args->PeekNext());
+    args->Skip();
+  }
 
-  if (is_drag_mode_ && pressed_button_ == WebMouseEvent::ButtonLeft &&
-      !replaying_saved_events_) {
-    SavedEvent saved_event;
-    saved_event.type = SavedEvent::TYPE_MOUSE_MOVE;
-    saved_event.pos = mouse_pos;
-    saved_event.modifiers = modifiers;
-    mouse_event_queue_.push_back(saved_event);
+  if (!getMousePenPointerTypeAndId(args, pointerType, pointerId))
+    return;
+
+  if (pointerType == blink::WebPointerProperties::PointerType::Mouse) {
+    if (is_drag_mode_ && current_pointer_state_[kMousePointerId].pressed_button_
+        == WebMouseEvent::ButtonLeft
+        && !replaying_saved_events_) {
+      SavedEvent saved_event;
+      saved_event.type = SavedEvent::TYPE_MOUSE_MOVE;
+      saved_event.pos = mouse_pos;
+      saved_event.modifiers = modifiers;
+      mouse_event_queue_.push_back(saved_event);
+    } else {
+      WebMouseEvent event;
+      InitMouseEvent(WebInputEvent::MouseMove,
+                     current_pointer_state_[kMousePointerId].pressed_button_,
+                     current_pointer_state_[kMousePointerId].current_buttons_,
+                     mouse_pos,
+                     GetCurrentEventTimeSec(),
+                     click_count_,
+                     modifiers,
+                     pointerType,
+                     0,

[mustaq, 2016/04/07 19:30:02]

Same as before, don't worry about pointerId, and unify the duplication.

[Navid Zolghadr, 2016/04/08 17:38:44]

Done.

+                     &event);
+      DoMouseMove(event);
+    }
   } else {
-    WebMouseEvent event;
-    InitMouseEvent(WebInputEvent::MouseMove,
-                   pressed_button_,
-                   current_buttons_,
-                   mouse_pos,
-                   GetCurrentEventTimeSec(),
-                   click_count_,
-                   modifiers,
-                   &event);
-    DoMouseMove(event);
+      current_pointer_state_[pointerId].last_pos_ = mouse_pos;
+
+      WebMouseEvent event;
+      InitMouseEvent(WebInputEvent::MouseMove,
+                     current_pointer_state_[pointerId].pressed_button_,
+                     current_pointer_state_[pointerId].current_buttons_,
+                     mouse_pos,
+                     GetCurrentEventTimeSec(),
+                     0,
+                     modifiers,
+                     pointerType,
+                     pointerId,
+                     &event);
+      HandleInputEventOnViewOrPopup(event);
   }
 }
 
 void EventSender::MouseLeave() {
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
 
   WebMouseEvent event;
   InitMouseEvent(WebInputEvent::MouseLeave,
                  WebMouseEvent::ButtonNone,
                  0,
-                 last_mouse_pos_,
+                 current_pointer_state_[kMousePointerId].last_pos_,
                  GetCurrentEventTimeSec(),
                  click_count_,
                  0,
+                 blink::WebPointerProperties::PointerType::Mouse,
+                 0,
                  &event);
   HandleInputEventOnViewOrPopup(event);
 }
 
 
 void EventSender::ScheduleAsynchronousClick(int button_number, int modifiers) {
   delegate_->PostTask(new MouseDownTask(this, button_number, modifiers));
   delegate_->PostTask(new MouseUpTask(this, button_number, modifiers));
 }
 
@@ skipping 291 matching lines @@
 
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
 
   WebInputEventResult result = HandleInputEventOnViewOrPopup(event);
 
   // Long press might start a drag drop session. Complete it if so.
   if (type == WebInputEvent::GestureLongPress && !current_drag_data_.isNull()) {
     WebMouseEvent mouse_event;
     InitMouseEvent(WebInputEvent::MouseDown,
-                   pressed_button_,
-                   current_buttons_,
+                   current_pointer_state_[kMousePointerId].pressed_button_,
+                   current_pointer_state_[kMousePointerId].current_buttons_,
                    WebPoint(x, y),
                    GetCurrentEventTimeSec(),
                    click_count_,
-                   modifiers_,
+                   current_pointer_state_[kMousePointerId].modifiers_,
+                   blink::WebPointerProperties::PointerType::Mouse,
+                   0,
                    &mouse_event);
 
     FinishDragAndDrop(mouse_event, blink::WebDragOperationNone);
   }
   args->Return(result != WebInputEventResult::NotHandled);
 }
 
 void EventSender::UpdateClickCountForButton(
     WebMouseEvent::Button button_type) {
   if ((GetCurrentEventTimeSec() - last_click_time_sec_ <
-       kMultipleClickTimeSec) &&
-      (!OutsideMultiClickRadius(last_mouse_pos_, last_click_pos_)) &&
-      (button_type == last_button_type_)) {
+      kMultipleClickTimeSec) &&
+      (!OutsideMultiClickRadius(
+      current_pointer_state_[kMousePointerId].last_pos_, last_click_pos_))
+      && (button_type == last_button_type_)) {
     ++click_count_;
   } else {
     click_count_ = 1;
     last_button_type_ = button_type;
   }
 }
 
 void EventSender::InitMouseWheelEvent(gin::Arguments* args,
                                       MouseScrollType scroll_type,
                                       WebMouseWheelEvent* event,
@@ skipping 32 matching lines @@
         }
       }
     }
   }
   if (can_scroll && send_wheel_gestures_) {
     can_scroll = false;
     *send_gestures = true;
   }
 
   InitMouseEvent(WebInputEvent::MouseWheel,
-                 pressed_button_,
-                 current_buttons_,
-                 last_mouse_pos_,
+                 current_pointer_state_[kMousePointerId].pressed_button_,
+                 current_pointer_state_[kMousePointerId].current_buttons_,
+                 current_pointer_state_[kMousePointerId].last_pos_,
                  GetCurrentEventTimeSec(),
                  click_count_,
                  modifiers,
+                 blink::WebPointerProperties::PointerType::Mouse,
+                 0,
                  event);
   event->wheelTicksX = static_cast<float>(horizontal);
   event->wheelTicksY = static_cast<float>(vertical);
   event->deltaX = event->wheelTicksX;
   event->deltaY = event->wheelTicksY;
   event->scrollByPage = paged;
   event->hasPreciseScrollingDeltas = has_precise_scrolling_deltas;
   event->canScroll = can_scroll;
   if (scroll_type == MouseScrollType::PIXEL) {
     event->wheelTicksX /= kScrollbarPixelsPerTick;
@@ skipping 42 matching lines @@
   if (!args->PeekNext().IsEmpty()) {
     int tiltX, tiltY;
     if (!args->GetNext(&tiltX) || !args->GetNext(&tiltY)) {
       args->ThrowError();
       return;
     }
     e->tiltX = tiltX;
     e->tiltY = tiltY;
   }
 
-  if (!args->PeekNext().IsEmpty()) {
-    std::string pointer_type_string;
-    if (!args->GetNext(&pointer_type_string)) {
-      args->ThrowError();
-      return;
-    }
-    if (pointer_type_string == kPointerTypeStringUnknown) {
-      e->pointerType = WebMouseEvent::PointerType::Unknown;
-    } else if (pointer_type_string == kPointerTypeStringMouse) {
-      e->pointerType = WebMouseEvent::PointerType::Mouse;
-    } else if (pointer_type_string == kPointerTypeStringPen) {
-      e->pointerType = WebMouseEvent::PointerType::Pen;
-    } else if (pointer_type_string == kPointerTypeStringTouch) {
-      e->pointerType = WebMouseEvent::PointerType::Touch;
-    } else {
-      args->ThrowError();
-      return;
-    }
-  }
+  if (!getPointerType(args, e->pointerType))
+    return;
 }
 
 void EventSender::FinishDragAndDrop(const WebMouseEvent& e,
                                      blink::WebDragOperation drag_effect) {
   WebPoint client_point(e.x, e.y);
   WebPoint screen_point(e.globalX, e.globalY);
   current_drag_effect_ = drag_effect;
   if (current_drag_effect_) {
     // Specifically pass any keyboard modifiers to the drop method. This allows
     // tests to control the drop type (i.e. copy or move).
     view_->dragTargetDrop(client_point, screen_point, e.modifiers);
   } else {
     view_->dragTargetDragLeave();
   }
   view_->dragSourceEndedAt(client_point, screen_point, current_drag_effect_);
   view_->dragSourceSystemDragEnded();
 
   current_drag_data_.reset();
 }
 
 void EventSender::DoMouseUp(const WebMouseEvent& e) {
   HandleInputEventOnViewOrPopup(e);
 
   last_click_time_sec_ = e.timeStampSeconds;
-  last_click_pos_ = last_mouse_pos_;
+  last_click_pos_ = current_pointer_state_[kMousePointerId].last_pos_;
 
   // If we're in a drag operation, complete it.
   if (current_drag_data_.isNull())
     return;
 
   WebPoint client_point(e.x, e.y);
   WebPoint screen_point(e.globalX, e.globalY);
   blink::WebDragOperation drag_effect = view_->dragTargetDragOver(
       client_point,
       screen_point,
       current_drag_effects_allowed_,
       e.modifiers);
 
   // Bail if dragover caused cancellation.
   if (current_drag_data_.isNull())
     return;
 
   FinishDragAndDrop(e, drag_effect);
 }
 
 void EventSender::DoMouseMove(const WebMouseEvent& e) {
-  last_mouse_pos_ = WebPoint(e.x, e.y);
+  current_pointer_state_[kMousePointerId].last_pos_ = WebPoint(e.x, e.y);
 
   HandleInputEventOnViewOrPopup(e);
 
-  if (pressed_button_ == WebMouseEvent::ButtonNone ||
-      current_drag_data_.isNull()) {
+  if (current_pointer_state_[kMousePointerId].pressed_button_
+      == WebMouseEvent::ButtonNone
+      || current_drag_data_.isNull()) {
     return;
   }
 
   WebPoint client_point(e.x, e.y);
   WebPoint screen_point(e.globalX, e.globalY);
   current_drag_effect_ = view_->dragTargetDragOver(
       client_point, screen_point, current_drag_effects_allowed_, e.modifiers);
 }
 
 void EventSender::ReplaySavedEvents() {
   replaying_saved_events_ = true;
   while (!mouse_event_queue_.empty()) {
     SavedEvent e = mouse_event_queue_.front();
     mouse_event_queue_.pop_front();
 
     switch (e.type) {
       case SavedEvent::TYPE_MOUSE_MOVE: {
         WebMouseEvent event;
         InitMouseEvent(WebInputEvent::MouseMove,
-                       pressed_button_,
-                       current_buttons_,
+                       current_pointer_state_[kMousePointerId].pressed_button_,
+                       current_pointer_state_[kMousePointerId].current_buttons_,
                        e.pos,
                        GetCurrentEventTimeSec(),
                        click_count_,
                        e.modifiers,
+                       blink::WebPointerProperties::PointerType::Mouse,
+                       0,
                        &event);
         DoMouseMove(event);
         break;
       }
       case SavedEvent::TYPE_LEAP_FORWARD:
         DoLeapForward(e.milliseconds);
         break;
       case SavedEvent::TYPE_MOUSE_UP: {
-        current_buttons_ &= ~GetWebMouseEventModifierForButton(e.button_type);
-        pressed_button_ = WebMouseEvent::ButtonNone;
+        current_pointer_state_[kMousePointerId].current_buttons_ &=
+            ~GetWebMouseEventModifierForButton(e.button_type);
+        current_pointer_state_[kMousePointerId].pressed_button_ =
+            WebMouseEvent::ButtonNone;
 
         WebMouseEvent event;
         InitMouseEvent(WebInputEvent::MouseUp,
                        e.button_type,
-                       current_buttons_,
-                       last_mouse_pos_,
+                       current_pointer_state_[kMousePointerId].current_buttons_,
+                       current_pointer_state_[kMousePointerId].last_pos_,
                        GetCurrentEventTimeSec(),
                        click_count_,
                        e.modifiers,
+                       blink::WebPointerProperties::PointerType::Mouse,
+                       0,
                        &event);
         DoMouseUp(event);
         break;
       }
       default:
         NOTREACHED();
     }
   }
 
   replaying_saved_events_ = false;
@@ skipping 61 matching lines @@
                                  &end_event);
   end_event.data.scrollEnd.deltaUnits =
       begin_event.data.scrollBegin.deltaHintUnits;
 
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
   HandleInputEventOnViewOrPopup(end_event);
 }
 
 }  // namespace test_runner