Consider isPrimary and pointerType when preventing compat mouse

third_party/WebKit/Source/core/input/PointerEventManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/PointerEventManager.h"
 
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/events/MouseEvent.h"
 #include "core/input/EventHandler.h"
 
 namespace blink {
 
 namespace {
 
+inline size_t toPointerTypeIndex(WebPointerProperties::PointerType t) { return static_cast<size_t>(t); }

[dtapuska, 2016/04/08 17:50:29]

I'd remove the inline. The compiler will handle the cast just fine.

[Navid Zolghadr, 2016/04/08 18:57:00]

Done.

+
 const AtomicString& pointerEventNameForTouchPointState(PlatformTouchPoint::TouchState state)
 {
     switch (state) {
     case PlatformTouchPoint::TouchReleased:
         return EventTypeNames::pointerup;
     case PlatformTouchPoint::TouchCancelled:
         return EventTypeNames::pointercancel;
     case PlatformTouchPoint::TouchPressed:
         return EventTypeNames::pointerdown;
     case PlatformTouchPoint::TouchMoved:
@@ skipping 83 matching lines @@
     // Pointer event type does not matter as it will be overridden in the sendNodeTransitionEvents
     PointerEvent* pointerEvent =
         m_pointerEventFactory.create(EventTypeNames::mouseout, mouseEvent,
         nullptr, view);
 
     // TODO(crbug/545647): This state should reset with pointercancel too.
     // This function also gets called for compat mouse events of touch at this
     // stage. So if the event is not frame boundary transition it is only a
     // compatibility mouse event and we do not need to change pointer event
     // behavior regarding preventMouseEvent state in that case.
-    if (isFrameBoundaryTransition && pointerEvent->buttons() == 0) {
-        m_preventMouseEventForPointerTypeMouse = false;
+    if (isFrameBoundaryTransition && pointerEvent->buttons() == 0
+        && pointerEvent->isPrimary()) {
+        m_preventMouseEventForPointerType[toPointerTypeIndex(
+            mouseEvent.pointerProperties().pointerType)] = false;
     }
 
     processCaptureAndPositionOfPointerEvent(pointerEvent, enteredNode,
         exitedNode, mouseEvent, true, isFrameBoundaryTransition);
 }
 
 void PointerEventManager::sendNodeTransitionEvents(
     EventTarget* exitedTarget,
     EventTarget* enteredTarget,
     PointerEvent* pointerEvent,
@@ skipping 218 matching lines @@
     Node* relatedTarget,
     AbstractView* view,
     Node* lastNodeUnderMouse)
 {
     PointerEvent* pointerEvent =
         m_pointerEventFactory.create(mouseEventType, mouseEvent,
         relatedTarget, view);
 
     // This is for when the mouse is released outside of the page.
     if (pointerEvent->type() == EventTypeNames::pointermove
-        && !pointerEvent->buttons()) {
-        m_preventMouseEventForPointerTypeMouse = false;
+        && !pointerEvent->buttons()
+        && pointerEvent->isPrimary()) {
+        m_preventMouseEventForPointerType[toPointerTypeIndex(
+            mouseEvent.pointerProperties().pointerType)] = false;
     }
 
     processCaptureAndPositionOfPointerEvent(pointerEvent, target,
         lastNodeUnderMouse, mouseEvent, true, true);
 
     EventTarget* effectiveTarget =
         getEffectiveTargetForPointerEvent(target, pointerEvent->pointerId());
 
     WebInputEventResult result =
         dispatchPointerEvent(effectiveTarget, pointerEvent);
 
     if (result != WebInputEventResult::NotHandled
-        && pointerEvent->type() == EventTypeNames::pointerdown)
-        m_preventMouseEventForPointerTypeMouse = true;
+        && pointerEvent->type() == EventTypeNames::pointerdown
+        && pointerEvent->isPrimary()) {
+        m_preventMouseEventForPointerType[toPointerTypeIndex(
+            mouseEvent.pointerProperties().pointerType)] = true;
+    }
 
-    if (!m_preventMouseEventForPointerTypeMouse) {
+    if (pointerEvent->isPrimary() && !m_preventMouseEventForPointerType[toPointerTypeIndex(
+        mouseEvent.pointerProperties().pointerType)]) {
         result = EventHandler::mergeEventResult(result,
             dispatchMouseEvent(effectiveTarget, mouseEventType, mouseEvent,
             nullptr, clickCount));
     }
 
     if (pointerEvent->buttons() == 0) {
         releasePointerCapture(pointerEvent->pointerId());
-        m_preventMouseEventForPointerTypeMouse = false;
+        if (pointerEvent->isPrimary()) {
+            m_preventMouseEventForPointerType[toPointerTypeIndex(
+                mouseEvent.pointerProperties().pointerType)] = false;
+        }
     }
 
     return result;
 }
 
 PointerEventManager::PointerEventManager()
 {
     clear();
 }
 
 PointerEventManager::~PointerEventManager()
 {
 }
 
 void PointerEventManager::clear()
 {
-    m_preventMouseEventForPointerTypeMouse = false;
+    for (auto& entry : m_preventMouseEventForPointerType)
+        entry = false;
     m_pointerEventFactory.clear();
     m_nodeUnderPointer.clear();
     m_pointerCaptureTarget.clear();
     m_pendingPointerCaptureTarget.clear();
 }
 
 void PointerEventManager::processCaptureAndPositionOfPointerEvent(
     PointerEvent* pointerEvent,
     EventTarget* hitTestTarget,
     EventTarget* lastNodeUnderMouse,
@@ skipping 159 matching lines @@
 
 DEFINE_TRACE(PointerEventManager)
 {
     visitor->trace(m_nodeUnderPointer);
     visitor->trace(m_pointerCaptureTarget);
     visitor->trace(m_pendingPointerCaptureTarget);
 }
 
 
 } // namespace blink