Issue 18555007: Bug fix in analysis engine, implementation of new error code to prevent type parameters in static m…

Issue 18555007: Bug fix in analysis engine, implementation of new error code to prevent type parameters in static m… (Closed)

Created:
7 years, 5 months ago by jwren

Modified:
7 years, 5 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bug fix in analysis engine, implementation of new error code to prevent type parameters in static members R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=24718

Patch Set 2 : Comment from Konstantin- fix. #

Total comments: 4

Patch Set 3 : Rebase with master #

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -7 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	6 chunks	+37 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View		1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/18555007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/18555007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode4087 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4087: errorReporter.reportError(StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC, node); return true;

7 years, 5 months ago (2013-07-02 22:29:13 UTC) #2

jwren

https://codereview.chromium.org/18555007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/18555007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode4087 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4087: errorReporter.reportError(StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC, node); On 2013/07/02 22:29:13, scheglov wrote: > return ...

7 years, 5 months ago (2013-07-02 22:34:03 UTC) #3

Brian Wilkerson

LGTM, with or without changes https://codereview.chromium.org/18555007/diff/5001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/18555007/diff/5001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode821 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:821: StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC); Could we remove ...

7 years, 5 months ago (2013-07-02 23:09:56 UTC) #5

jwren

https://codereview.chromium.org/18555007/diff/5001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/18555007/diff/5001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode821 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:821: StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC); I had a similar thought, removing "static" yeilds ...

7 years, 5 months ago (2013-07-03 06:47:03 UTC) #6

jwren

7 years, 5 months ago (2013-07-03 06:48:06 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 manually as r24718 (presubmit successful).

Expand Messages | Collapse Messages