Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1855483004: [iOS/OS X] Allow base::scoped_nsobject<> to be used when ARC is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to build/config/compiler/BUILD.gn Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 10
(...skipping 1273 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 } 1284 }
1285 if (is_win_fastlink && visual_studio_version != "2013") { 1285 if (is_win_fastlink && visual_studio_version != "2013") {
1286 # Tell VS 2015+ to create a PDB that references debug 1286 # Tell VS 2015+ to create a PDB that references debug
1287 # information in .obj and .lib files instead of copying 1287 # information in .obj and .lib files instead of copying
1288 # it all. This flag is incompatible with /PROFILE 1288 # it all. This flag is incompatible with /PROFILE
1289 ldflags = [ "/DEBUG:FASTLINK" ] 1289 ldflags = [ "/DEBUG:FASTLINK" ]
1290 } else { 1290 } else {
1291 ldflags = [ "/DEBUG" ] 1291 ldflags = [ "/DEBUG" ]
1292 } 1292 }
1293 } else { 1293 } else {
1294 cflags = [ "-g2" ] 1294 if (!is_ios && !is_mac) {
1295 cflags = [ "-g2" ]
1296 } else {
1297 cflags = [ "-gdwarf-2" ]
Nico 2016/04/04 17:53:45 ?
1298 }
1295 if (use_debug_fission) { 1299 if (use_debug_fission) {
1296 cflags += [ "-gsplit-dwarf" ] 1300 cflags += [ "-gsplit-dwarf" ]
1297 } 1301 }
1298 asmflags = cflags 1302 asmflags = cflags
1299 ldflags = [] 1303 ldflags = []
1300 } 1304 }
1301 } 1305 }
1302 1306
1303 # Minimal symbols. 1307 # Minimal symbols.
1304 config("minimal_symbols") { 1308 config("minimal_symbols") {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 1350
1347 if (is_ios || is_mac) { 1351 if (is_ios || is_mac) {
1348 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1352 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1349 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1353 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1350 config("enable_arc") { 1354 config("enable_arc") {
1351 common_flags = [ "-fobjc-arc" ] 1355 common_flags = [ "-fobjc-arc" ]
1352 cflags_objc = common_flags 1356 cflags_objc = common_flags
1353 cflags_objcc = common_flags 1357 cflags_objcc = common_flags
1354 } 1358 }
1355 } 1359 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698