Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1855483003: Store initializer expressions for untyped vars/fields in summaries. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store initializer expressions for untyped vars/fields in summaries. These will be needed for type inference. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/10fcf65d6fd91977251446b16d63ebc60bef2517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-01 19:16:25 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-01 19:26:01 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-04 16:19:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10fcf65d6fd91977251446b16d63ebc60bef2517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698