Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1855473002: Triage some precompilation failures, mostly related to the service isolate no longer being started. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Triage some precompilation failures, mostly related to the service isolate no longer being started. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/36d0cfced8db372d4bd7aba471b93ff483df131c

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tests/corelib/corelib.status View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-01 16:53:03 UTC) #2
siva
lgtm
4 years, 8 months ago (2016-04-01 17:12:19 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-01 17:28:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
36d0cfced8db372d4bd7aba471b93ff483df131c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698