Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1855463002: Remove "#pragma comment(lib" in ui. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "#pragma comment(lib" in ui. BUG=597028 Committed: https://crrev.com/20de469cfbc01e3858d7329cc0820da1093437b5 Cr-Commit-Position: refs/heads/master@{#384645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M ui/base/ime/win/imm32_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/win/windows_session_change_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
4 years, 8 months ago (2016-04-01 17:35:40 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-01 17:51:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855463002/1
4 years, 8 months ago (2016-04-01 18:09:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 18:50:38 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:52:35 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/20de469cfbc01e3858d7329cc0820da1093437b5
Cr-Commit-Position: refs/heads/master@{#384645}

Powered by Google App Engine
This is Rietveld 408576698