Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1855453002: Remove registered_task_queues_ and associated DCHECKS from TimeDomain (Closed)

Created:
4 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove registered_task_queues_ and associated DCHECKS from TimeDomain TSAN is complaining about the usage of |registered_task_queues_| and since they where added purely to diagnose a UAF which we've fixed we might as well rip them out again. BUG=599535 Committed: https://crrev.com/6c6e2a5feb305732656ece32e0eac30c33673345 Cr-Commit-Position: refs/heads/master@{#384603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M components/scheduler/base/time_domain.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/scheduler/base/time_domain.cc View 5 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855453002/1
4 years, 8 months ago (2016-04-01 15:05:20 UTC) #2
alex clarke (OOO till 29th)
PTAL
4 years, 8 months ago (2016-04-01 15:05:32 UTC) #5
Sami
lgtm.
4 years, 8 months ago (2016-04-01 16:02:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855453002/1
4 years, 8 months ago (2016-04-01 16:07:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 16:33:44 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 16:35:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c6e2a5feb305732656ece32e0eac30c33673345
Cr-Commit-Position: refs/heads/master@{#384603}

Powered by Google App Engine
This is Rietveld 408576698