third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 1855443002: Implement receiving side of web notification inline replies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments & Tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html ('K') | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html ('k') | third_party/WebKit/Source/modules/notifications/NotificationAction.idl » ('j') | third_party/WebKit/Source/modules/notifications/NotificationAction.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index b22dbe35e0c097b5e488e2907c847854f46bf788..b15fabe239ed91be1a3f1dd09ad2c21b7397e4cb 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -302,9 +302,11 @@ HeapVector<NotificationAction> Notification::actions() const

actions.grow(m_data.actions.size());

for (size_t i = 0; i < m_data.actions.size(); ++i) {

+ actions[i].setType(m_data.actions[i].type);

actions[i].setAction(m_data.actions[i].action);

actions[i].setTitle(m_data.actions[i].title);

actions[i].setIcon(m_data.actions[i].icon.string());

+ actions[i].setPlaceholder(m_data.actions[i].placeholder);

}

return actions;