third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html - Issue 1855443002: Implement receiving side of web notification inline replies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments & Tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/notifications/notification_data_conversions.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationAction.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

index 2755ea673dc82ce6a538dc6f3e107ed36dd6d969..2dc12e93d2920b79eddd9457432a02aefbe3bbc1 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

@@ -54,9 +54,11 @@

// Deliberately add more actions than are supported.

for (var i = 0; i < 2 * Notification.maxActions; i++) {

options.actions.push({

+ type: i % 2 == 0 ? 'button' : 'text',

Mike West 2016/04/05 14:41:00 Can you add some tests for invalid values?

Nina 2016/04/05 16:10:01 This is taken care of automatically by the IDL gen

action: 'a' + i,

title: 'Action ' + i,

- icon: 'https://example/action_icon_' + i + '.png'

+ icon: 'https://example/action_icon_' + i + '.png',

+ placeholder: i % 2 == 0 ? null : 'Type a reply...'

});

}