content/common/platform_notification_messages.h - Issue 1855443002: Implement receiving side of web notification inline replies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/platform_notification_messages.h

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/notifications/notification_data_conversions.cc ('K') | « content/child/notifications/notification_data_conversions_unittest.cc ('k') | content/public/common/platform_notification_data.h » ('j') | third_party/WebKit/Source/modules/notifications/NotificationAction.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/platform_notification_messages.h

diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h

index 0ba110ffe91ba8b67ef1fa97ced9e6386d54a26a..5e5d8bb65f7d543ff89dea962ebc68d97cada28d 100644

--- a/content/common/platform_notification_messages.h

+++ b/content/common/platform_notification_messages.h

@@ -36,10 +36,15 @@ IPC_ENUM_TRAITS_MAX_VALUE(

content::PlatformNotificationData::Direction,

content::PlatformNotificationData::DIRECTION_LAST)

+IPC_ENUM_TRAITS_MAX_VALUE(content::PlatformNotificationActionType,

+ content::PLATFORM_NOTIFICATION_ACTION_TYPE_TEXT)

IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationAction)

+ IPC_STRUCT_TRAITS_MEMBER(type)

Michael van Ouwerkerk 2016/04/05 10:06:55 Please keep the same order of members throughout:

Nina 2016/04/05 13:28:22 I think I re-ordered everything in this order: typ

IPC_STRUCT_TRAITS_MEMBER(action)

IPC_STRUCT_TRAITS_MEMBER(title)

IPC_STRUCT_TRAITS_MEMBER(icon)

+ IPC_STRUCT_TRAITS_MEMBER(placeholder)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationData)