Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Unified Diff: Source/devtools/front_end/TimelineOverviewPane.js

Issue 185543012: TimelinePanel: REGRESSIONS: three fixes for TimelineOverviewPane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/TimelineOverviewPane.js
diff --git a/Source/devtools/front_end/TimelineOverviewPane.js b/Source/devtools/front_end/TimelineOverviewPane.js
index 2e6072958165d9453796eff76c8b2ea30e192bd6..307c973982abe4802132ef7361ece5726a68616b 100644
--- a/Source/devtools/front_end/TimelineOverviewPane.js
+++ b/Source/devtools/front_end/TimelineOverviewPane.js
@@ -97,6 +97,7 @@ WebInspector.TimelineOverviewPane.prototype = {
this._overviewControl.update();
this._overviewGrid.updateDividers(this._overviewCalculator);
this._updateEventDividers();
+ this._updateWindow();
pfeldman 2014/03/04 06:26:52 This is strange since window has not changed. We s
},
_updateEventDividers: function()
@@ -152,6 +153,8 @@ WebInspector.TimelineOverviewPane.prototype = {
if (this._muteOnWindowChanged)
return;
var windowTimes = this._overviewControl.windowTimes(this._overviewGrid.windowLeft(), this._overviewGrid.windowRight());
+ this._windowStartTime = windowTimes.startTime;
pfeldman 2014/03/04 06:26:52 These three lines should be extracted (they are us
+ this._windowEndTime = windowTimes.endTime;
this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, windowTimes);
},
@@ -165,13 +168,17 @@ WebInspector.TimelineOverviewPane.prototype = {
return;
this._windowStartTime = startTime;
this._windowEndTime = endTime;
- var windowBoundaries = this._overviewControl.windowBoundaries(startTime, endTime);
+ this._updateWindow();
+ this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, { startTime: startTime, endTime: endTime });
+ },
+
+ _updateWindow: function()
+ {
+ var windowBoundaries = this._overviewControl.windowBoundaries(this._windowStartTime, this._windowEndTime);
this._muteOnWindowChanged = true;
this._overviewGrid.setWindow(windowBoundaries.left, windowBoundaries.right);
this._overviewGrid.setResizeEnabled(!!this._model.records().length);
this._muteOnWindowChanged = false;
-
- this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, { startTime: startTime, endTime: endTime });
},
_scheduleRefresh: function()
« Source/devtools/front_end/TimelineModel.js ('K') | « Source/devtools/front_end/TimelineModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698