TimelinePanel: REGRESSIONS: three fixes for TimelineOverviewPane.

Source/devtools/front_end/TimelineOverviewPane.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 79 matching lines @@
     _update: function()
     {
         delete this._refreshTimeout;
 
         this._overviewCalculator.setWindow(this._model.minimumRecordTime(), this._model.maximumRecordTime());
         this._overviewCalculator.setDisplayWindow(0, this._overviewGrid.clientWidth());
         if (this._overviewControl)
             this._overviewControl.update();
         this._overviewGrid.updateDividers(this._overviewCalculator);
         this._updateEventDividers();
+        this._updateWindow();

[pfeldman, 2014/03/04 06:26:52]

This is strange since window has not changed. We should make the grid belong and
update from the modes so that _overviewControl.windowBoundaries was not exposed.

     },
 
     _updateEventDividers: function()
     {
         var records = this._eventDividers;
         this._overviewGrid.removeEventDividers();
         var dividers = [];
         for (var i = 0; i < records.length; ++i) {
             var record = records[i];
             var positions = this._overviewCalculator.computeBarGraphPercentages(record);
@@ skipping 35 matching lines @@
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onWindowChanged: function(event)
     {
         if (this._muteOnWindowChanged)
             return;
         var windowTimes = this._overviewControl.windowTimes(this._overviewGrid.windowLeft(), this._overviewGrid.windowRight());
+        this._windowStartTime = windowTimes.startTime;

[pfeldman, 2014/03/04 06:26:52]

These three lines should be extracted (they are used in requestWindow times as
well).

+        this._windowEndTime = windowTimes.endTime;
         this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, windowTimes);
     },
 
     /**
      * @param {number} startTime
      * @param {number} endTime
      */
     requestWindowTimes: function(startTime, endTime)
     {
         if (startTime === this._windowStartTime && endTime === this._windowEndTime)
             return;
         this._windowStartTime = startTime;
         this._windowEndTime = endTime;
-        var windowBoundaries = this._overviewControl.windowBoundaries(startTime, endTime);
+        this._updateWindow();
+        this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, { startTime: startTime, endTime: endTime });
+    },
+
+    _updateWindow: function()
+    {
+        var windowBoundaries = this._overviewControl.windowBoundaries(this._windowStartTime, this._windowEndTime);
         this._muteOnWindowChanged = true;
         this._overviewGrid.setWindow(windowBoundaries.left, windowBoundaries.right);
         this._overviewGrid.setResizeEnabled(!!this._model.records().length);
         this._muteOnWindowChanged = false;
-
-        this.dispatchEventToListeners(WebInspector.TimelineOverviewPane.Events.WindowChanged, { startTime: startTime, endTime: endTime });
     },
 
     _scheduleRefresh: function()
     {
         if (this._refreshTimeout)
             return;
         if (!this.isShowing())
             return;
         this._refreshTimeout = setTimeout(this._update.bind(this), 300);
     },
@@ skipping 155 matching lines @@
     },
 
     resetCanvas: function()
     {
         this._canvas.width = this.element.clientWidth * window.devicePixelRatio;
         this._canvas.height = this.element.clientHeight * window.devicePixelRatio;
     },
 
     __proto__: WebInspector.View.prototype
 }