Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 185543012: TimelinePanel: REGRESSIONS: three fixes for TimelineOverviewPane. (Closed)

Created:
6 years, 9 months ago by loislo
Modified:
6 years, 9 months ago
Reviewers:
caseq, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

TimelinePanel: REGRESSIONS: three fixes for TimelineOverviewPane. 1) Selected window doesn't slide while recording. Why: there used to be a call for _updateWindow from _update method. 2) No overview for Events mode. Why: raw records may have no valid endTime. 3) The window selection is dropping by recording timeline. Why: earlier overview pane saved the selected time range at _onWindowChanged. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168367

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Source/devtools/front_end/TimelineModel.js View 1 chunk +1 line, -1 line 1 comment Download
M Source/devtools/front_end/TimelineOverviewPane.js View 3 chunks +10 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
loislo
6 years, 9 months ago (2014-03-04 05:59:05 UTC) #1
pfeldman
https://codereview.chromium.org/185543012/diff/1/Source/devtools/front_end/TimelineModel.js File Source/devtools/front_end/TimelineModel.js (right): https://codereview.chromium.org/185543012/diff/1/Source/devtools/front_end/TimelineModel.js#newcode360 Source/devtools/front_end/TimelineModel.js:360: _updateBoundaries: function(record) This should be called on the WebInspector.TimlineModel.Record ...
6 years, 9 months ago (2014-03-04 06:26:51 UTC) #2
pfeldman
lgtm
6 years, 9 months ago (2014-03-04 06:51:21 UTC) #3
loislo
6 years, 9 months ago (2014-03-04 07:10:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r168367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698