Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 185543008: Revert of Omit protocol part in URLs in changelog pages. (Closed)

Created:
6 years, 9 months ago by ghost stip (do not use)
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/tools/perf.git@master
Visibility:
Public.

Description

Revert of Omit protocol part in URLs in changelog pages. (https://codereview.chromium.org/148963013/) Reason for revert: This just got sync'd on the masters and it's causing errors for the revision ranges: Going here: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=168128%3A168234&mode=html leads to a bad request here: http://build.chromium.org/cgi-bin/svn-log?url=//src.chromium.org/blink//trunk&range=168128:168234 Original issue's description: > Omit protocol part in URLs in changelog pages. > > Reason for this change: > In the past, build.chromium.org was HTTP-only, and so it couldn't be directly put in an iframe on the perf dashboard which uses HTTPS. Annie Sullivan made a page on the perf dashboard, /revision_proxy to get around this. > > Now, build.chromium.org supports HTTPS, and I wanted to switch the changelog viewer links that the dashboard uses to HTTPS. The purpose of this CL is to make the changelog viewer pages work the same with both HTTP and HTTPS. > > BUG= TBR=kjellander@chromium.org,qyearsley@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=254498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M dashboard/ui/changelog.html View 1 chunk +2 lines, -2 lines 0 comments Download
M dashboard/ui/changelog_blink.html View 1 chunk +2 lines, -2 lines 0 comments Download
M dashboard/ui/changelog_v8.html View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/ui/changelog_webrtc.html View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/ui/js/changelog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ghost stip (do not use)
Created Revert of Omit protocol part in URLs in changelog pages.
6 years, 9 months ago (2014-03-03 17:52:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/185543008/1
6 years, 9 months ago (2014-03-03 17:52:13 UTC) #2
commit-bot: I haz the power
Change committed as 254498
6 years, 9 months ago (2014-03-03 17:52:20 UTC) #3
qyearsley
6 years, 9 months ago (2014-03-03 17:57:00 UTC) #4
Message was sent while issue was closed.
On 2014/03/03 17:52:20, I haz the power (commit-bot) wrote:
> Change committed as 254498

Aww... I'll have to look closer at why this was happening before making another
CL.

Powered by Google App Engine
This is Rietveld 408576698