Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: tests/standalone/io/http_content_length_test.dart

Issue 185543004: Merge all http-outgoing transfomers into _HttpOutgoing, including simpler(better) buffering. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Cleanup Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_close_test.dart ('k') | tests/standalone/io/http_outgoing_size_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_content_length_test.dart
diff --git a/tests/standalone/io/http_content_length_test.dart b/tests/standalone/io/http_content_length_test.dart
index 627b28fee53b9cf09f20b1a41f0049344d1ef399..5094c43b2fdac9a022f9a94d768c125463ecbec2 100644
--- a/tests/standalone/io/http_content_length_test.dart
+++ b/tests/standalone/io/http_content_length_test.dart
@@ -63,9 +63,7 @@ void testNoBody(int totalConnections, bool explicitContentLength) {
response.drain();
})
.catchError((e, trace) {
- String msg = "Unexpected error $e";
- if (trace != null) msg += "\nStackTrace: $trace";
- Expect.fail(msg);
+ // It's also okay to fail, as headers may not be written.
});
}
});
@@ -142,6 +140,9 @@ void testBody(int totalConnections, bool useHeader) {
onError: (error, trace) {
// Undefined what server response sends.
});
+ })
+ .catchError((error) {
+ // It's also okay to fail, as headers may not be written.
});
}
});
« no previous file with comments | « tests/standalone/io/http_close_test.dart ('k') | tests/standalone/io/http_outgoing_size_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698