Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: sdk/lib/io/io_sink.dart

Issue 185543004: Merge all http-outgoing transfomers into _HttpOutgoing, including simpler(better) buffering. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Cleanup Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/http_10_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart.io; 5 part of dart.io;
6 6
7 /** 7 /**
8 * Helper class to wrap a [StreamConsumer<List<int>>] and provide 8 * Helper class to wrap a [StreamConsumer<List<int>>] and provide
9 * utility functions for writing to the StreamConsumer directly. The 9 * utility functions for writing to the StreamConsumer directly. The
10 * [IOSink] buffers the input given by all [StringSink] methods and will delay 10 * [IOSink] buffers the input given by all [StringSink] methods and will delay
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 _isBound = false; 103 _isBound = false;
104 }); 104 });
105 } 105 }
106 if (_controllerInstance == null) return targetAddStream(); 106 if (_controllerInstance == null) return targetAddStream();
107 var future = _controllerCompleter.future; 107 var future = _controllerCompleter.future;
108 _controllerInstance.close(); 108 _controllerInstance.close();
109 return future.then((_) => targetAddStream()); 109 return future.then((_) => targetAddStream());
110 } 110 }
111 111
112 Future flush() { 112 Future flush() {
113 if (_isBound) {
114 throw new StateError("StreamSink is bound to a stream");
115 }
116 if (_controllerInstance == null) return new Future.value(this);
113 // Adding an empty stream-controller will return a future that will complete 117 // Adding an empty stream-controller will return a future that will complete
114 // when all data is done. 118 // when all data is done.
115 var controller = new StreamController()..close(); 119 _isBound = true;
116 return addStream(controller.stream).then((_) => this); 120 var future = _controllerCompleter.future;
121 _controllerInstance.close();
122 return future.whenComplete(() {
123 _isBound = false;
124 });
117 } 125 }
118 126
119 Future close() { 127 Future close() {
120 if (_isBound) { 128 if (_isBound) {
121 throw new StateError("StreamSink is bound to a stream"); 129 throw new StateError("StreamSink is bound to a stream");
122 } 130 }
123 if (!_isClosed) { 131 if (!_isClosed) {
124 _isClosed = true; 132 _isClosed = true;
125 if (_controllerInstance != null) { 133 if (_controllerInstance != null) {
126 _controllerInstance.close(); 134 _controllerInstance.close();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 throw new StateError("StreamSink is closed"); 166 throw new StateError("StreamSink is closed");
159 } 167 }
160 if (_controllerInstance == null) { 168 if (_controllerInstance == null) {
161 _controllerInstance = new StreamController<T>(sync: true); 169 _controllerInstance = new StreamController<T>(sync: true);
162 _controllerCompleter = new Completer(); 170 _controllerCompleter = new Completer();
163 _target.addStream(_controller.stream) 171 _target.addStream(_controller.stream)
164 .then( 172 .then(
165 (_) { 173 (_) {
166 if (_isBound) { 174 if (_isBound) {
167 // A new stream takes over - forward values to that stream. 175 // A new stream takes over - forward values to that stream.
168 _controllerCompleter.complete(); 176 _controllerCompleter.complete(this);
169 _controllerCompleter = null; 177 _controllerCompleter = null;
170 _controllerInstance = null; 178 _controllerInstance = null;
171 } else { 179 } else {
172 // No new stream, .close was called. Close _target. 180 // No new stream, .close was called. Close _target.
173 _closeTarget(); 181 _closeTarget();
174 } 182 }
175 }, 183 },
176 onError: (error) { 184 onError: (error) {
177 if (_isBound) { 185 if (_isBound) {
178 // A new stream takes over - forward errors to that stream. 186 // A new stream takes over - forward errors to that stream.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 String string; 222 String string;
215 if (obj is String) { 223 if (obj is String) {
216 string = obj; 224 string = obj;
217 } else { 225 } else {
218 string = obj.toString(); 226 string = obj.toString();
219 if (string is! String) { 227 if (string is! String) {
220 throw new ArgumentError('toString() did not return a string'); 228 throw new ArgumentError('toString() did not return a string');
221 } 229 }
222 } 230 }
223 if (string.isEmpty) return; 231 if (string.isEmpty) return;
224 add(_encoding.encode(string)); 232 add(encoding.encode(string));
225 } 233 }
226 234
227 void writeAll(Iterable objects, [String separator = ""]) { 235 void writeAll(Iterable objects, [String separator = ""]) {
228 Iterator iterator = objects.iterator; 236 Iterator iterator = objects.iterator;
229 if (!iterator.moveNext()) return; 237 if (!iterator.moveNext()) return;
230 if (separator.isEmpty) { 238 if (separator.isEmpty) {
231 do { 239 do {
232 write(iterator.current); 240 write(iterator.current);
233 } while (iterator.moveNext()); 241 } while (iterator.moveNext());
234 } else { 242 } else {
235 write(iterator.current); 243 write(iterator.current);
236 while (iterator.moveNext()) { 244 while (iterator.moveNext()) {
237 write(separator); 245 write(separator);
238 write(iterator.current); 246 write(iterator.current);
239 } 247 }
240 } 248 }
241 } 249 }
242 250
243 void writeln([Object obj = ""]) { 251 void writeln([Object obj = ""]) {
244 write(obj); 252 write(obj);
245 write("\n"); 253 write("\n");
246 } 254 }
247 255
248 void writeCharCode(int charCode) { 256 void writeCharCode(int charCode) {
249 write(new String.fromCharCode(charCode)); 257 write(new String.fromCharCode(charCode));
250 } 258 }
251 } 259 }
OLDNEW
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/http_10_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698