Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 185543003: Remove check_url_directory flag from clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.h ('k') | tools/clang/plugins/FindBadConstructs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index 94e89f7a02d1812e05190fecc0359d3f3d05ad4e..1fbd42a5c0eb30963079683a28ac0818e40786ee 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -36,11 +36,9 @@ bool ends_with(const std::string& one, const std::string& two) {
} // namespace
-ChromeClassTester::ChromeClassTester(CompilerInstance& instance,
- bool check_url_directory)
+ChromeClassTester::ChromeClassTester(CompilerInstance& instance)
: instance_(instance),
- diagnostic_(instance.getDiagnostics()),
- check_url_directory_(check_url_directory) {
+ diagnostic_(instance.getDiagnostics()) {
BuildBannedLists();
}
@@ -170,9 +168,6 @@ void ChromeClassTester::BuildBannedLists() {
banned_directories_.push_back("icu4c/");
banned_directories_.push_back("frameworks/");
- if (!check_url_directory_)
- banned_directories_.push_back("url/");
-
// Don't check autogenerated headers.
// Make puts them below $(builddir_name)/.../gen and geni.
// Ninja puts them below OUTPUT_DIR/.../gen
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.h ('k') | tools/clang/plugins/FindBadConstructs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698