Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: components/omnibox/browser/omnibox_view.h

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted autocomplete_text_field* Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_view.h
diff --git a/components/omnibox/browser/omnibox_view.h b/components/omnibox/browser/omnibox_view.h
index f092f5281be9cfa38bd7cdfa8822264fa1d04dcc..614b0a4c69a8d6d3c13d63dc71ddc254c6edeb73 100644
--- a/components/omnibox/browser/omnibox_view.h
+++ b/components/omnibox/browser/omnibox_view.h
@@ -98,13 +98,10 @@ class OmniboxView {
bool update_popup,
bool notify_text_changed) = 0;
- // Sets the edit to forced query mode. Practically speaking, this means that
- // if the edit is not in forced query mode, its text is set to "?" with the
- // cursor at the end, and if the edit is in forced query mode (its first
- // non-whitespace character is '?'), the text after the '?' is selected.
- //
- // In the future we should display the search engine UI for the default engine
- // rather than '?'.
+ // Transition the user into keyword mode with their default search provider.
Peter Kasting 2016/04/08 00:39:56 Nit: Function comments should be declarative, not
Tom (Use chromium acct) 2016/04/12 20:03:05 Done.
+ // If the user has already typed some text, preserve it in the query. If the
+ // user is already in keyword mode (with any search provider), select their
+ // query.
virtual void SetForcedQuery() = 0;
// Returns true if all text is selected or there is no text at all.

Powered by Google App Engine
This is Rietveld 408576698