Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3731)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add includes for mac tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
index b2fc27a0a59389db1371ab942404a77e53ecfad3..8a25ea1c3d55e9d667518f7ed65f7247e9d22edf 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
@@ -15,6 +15,7 @@
#include "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"
#include "components/omnibox/browser/omnibox_view.h"
#include "components/security_state/security_state_model.h"
+#include "third_party/skia/include/core/SKColor.h"
class CommandUpdater;
class OmniboxPopupView;
@@ -66,7 +67,7 @@ class OmniboxViewMac : public OmniboxView,
size_t caret_pos,
bool update_popup,
bool notify_text_changed) override;
- void SetForcedQuery() override;
+ void EnterKeywordModeForDefaultSearchProvider() override;
bool IsSelectAll() const override;
bool DeleteAtEndPressed() override;
void GetSelectionBounds(base::string16::size_type* start,
@@ -211,8 +212,7 @@ class OmniboxViewMac : public OmniboxView,
// Tracking state before and after a possible change for reporting
// to model_.
- NSRange selection_before_change_;
- base::string16 text_before_change_;
+ State state_before_change_;
NSRange marked_range_before_change_;
// Was delete pressed?

Powered by Google App Engine
This is Rietveld 408576698