chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really removed call to UpdatePopup Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

index 04a9f44710fb84857348a5aec276c0759b9cbfe7..36b7672da52605d904d9b2f218bf62c869179b9d 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

@@ -66,7 +66,7 @@ class OmniboxViewMac : public OmniboxView,

size_t caret_pos,

bool update_popup,

bool notify_text_changed) override;

- void SetForcedQuery() override;

+ void EnterKeywordModeForDefaultSearchProvider() override;

bool IsSelectAll() const override;

bool DeleteAtEndPressed() override;

void GetSelectionBounds(base::string16::size_type* start,

@@ -214,6 +214,8 @@ class OmniboxViewMac : public OmniboxView,

// to model_.

NSRange selection_before_change_;

base::string16 text_before_change_;

+ base::string16 keyword_before_change_;

+ bool is_keyword_selected_before_change_;

NSRange marked_range_before_change_;

// Was delete pressed?