components/omnibox/browser/omnibox_edit_unittest.cc - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_edit_unittest.cc

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, make '?' enter keyword mode on nonempty inputs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/omnibox/browser/omnibox_edit_model.cc ('K') | « components/omnibox/browser/omnibox_edit_model.cc ('k') | components/omnibox/browser/omnibox_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/omnibox_edit_unittest.cc

diff --git a/components/omnibox/browser/omnibox_edit_unittest.cc b/components/omnibox/browser/omnibox_edit_unittest.cc

index 77c16114c759d48e92ad76ea840ad429187b3815..7e98acbc44ad13f76679b7df74a14f66f2837ed2 100644

--- a/components/omnibox/browser/omnibox_edit_unittest.cc

+++ b/components/omnibox/browser/omnibox_edit_unittest.cc

@@ -51,7 +51,8 @@ class TestingOmniboxView : public OmniboxView {

bool notify_text_changed) override {

text_ = text;

}

- void SetForcedQuery() override {}

+ void SetCaretPos(size_t caret_pos) override {}

+ void EnterKeywordModeForDefaultSearchProvider() override {}

bool IsSelectAll() const override { return false; }

bool DeleteAtEndPressed() override { return false; }

void GetSelectionBounds(size_t* start, size_t* end) const override {}

@@ -346,7 +347,7 @@ TEST_F(OmniboxEditTest, InlineAutocompleteText) {

EXPECT_EQ(UTF8ToUTF16("llo"), view.inline_autocomplete_text());

model.OnAfterPossibleChange(UTF8ToUTF16("he"), UTF8ToUTF16("hel"), 3, 3,

- false, true, false, true);

+ false, true, false, false, true);

EXPECT_EQ(base::string16(), view.inline_autocomplete_text());

model.OnPopupDataChanged(UTF8ToUTF16("lo"), NULL, base::string16(), false);

EXPECT_EQ(UTF8ToUTF16("hello"), view.GetText());