chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, make '?' enter keyword mode on nonempty inputs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_browsertest.cc ('K') | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | components/omnibox/browser/omnibox_edit_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index b12098d3e296bf865ad06f843b5990c5e8b9d5e6..72195612cd589da9551f115d19fc39728ac0d156 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -89,7 +89,7 @@ class OmniboxViewViews

base::string16 GetText() const override;

void SetUserText(const base::string16& text,

bool update_popup) override;

- void SetForcedQuery() override;

+ void EnterKeywordModeForDefaultSearchProvider() override;

void GetSelectionBounds(base::string16::size_type* start,

base::string16::size_type* end) const override;

void SelectAll(bool reversed) override;

@@ -223,6 +223,8 @@ class OmniboxViewViews

// Tracking state before and after a possible change.

base::string16 text_before_change_;

+ base::string16 keyword_before_change_;

+ bool is_keyword_selected_before_change_;

gfx::Range sel_before_change_;

bool ime_composing_before_change_;