Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: components/omnibox/browser/omnibox_view.h

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test compilation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_view.h
diff --git a/components/omnibox/browser/omnibox_view.h b/components/omnibox/browser/omnibox_view.h
index bb6326867433261a164c6b19a5d0760088d8df46..8c18d5fb65e5aadd6d9c9ecd56c71bfec397cc51 100644
--- a/components/omnibox/browser/omnibox_view.h
+++ b/components/omnibox/browser/omnibox_view.h
@@ -98,14 +98,12 @@ class OmniboxView {
bool update_popup,
bool notify_text_changed) = 0;
- // Sets the edit to forced query mode. Practically speaking, this means that
- // if the edit is not in forced query mode, its text is set to "?" with the
- // cursor at the end, and if the edit is in forced query mode (its first
- // non-whitespace character is '?'), the text after the '?' is selected.
- //
- // In the future we should display the search engine UI for the default engine
- // rather than '?'.
- virtual void SetForcedQuery() = 0;
+ // Sets the caret position.
+ virtual void SetCaretPos(size_t caret_pos) = 0;
+
+ // Transitions the user into keyword mode with their default search provider,
+ // preserving and selecting the user's text if they already typed in a query.
+ virtual void EnterKeywordModeForDefaultSearchProvider() = 0;
// Returns true if all text is selected or there is no text at all.
virtual bool IsSelectAll() const = 0;

Powered by Google App Engine
This is Rietveld 408576698