components/omnibox/browser/base_search_provider.cc - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/base_search_provider.cc

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed forced queries using '?'. Removed Ctrl-K preserving the user's keyword if they're already … Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/omnibox/browser/autocomplete_result.cc ('K') | « components/omnibox/browser/autocomplete_result.cc ('k') | components/omnibox/browser/bookmark_provider.cc » ('j') | components/omnibox/browser/omnibox_edit_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/base_search_provider.cc

diff --git a/components/omnibox/browser/base_search_provider.cc b/components/omnibox/browser/base_search_provider.cc

index 55aa13228d72028d036e44e70e4f9693c626eeb2..916d544a74d7084472a95cbf22b589d40574df56 100644

--- a/components/omnibox/browser/base_search_provider.cc

+++ b/components/omnibox/browser/base_search_provider.cc

@@ -238,11 +238,6 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(

(base::CollapseWhitespace(input.text(), false) ==

suggestion.match_contents());

- // When the user forced a query, we need to make sure all the fill_into_edit

- // values preserve that property. Otherwise, if the user starts editing a

- // suggestion, non-Search results will suddenly appear.

- if (input.type() == metrics::OmniboxInputType::FORCED_QUERY)

- match.fill_into_edit.assign(base::ASCIIToUTF16("?"));

if (suggestion.from_keyword_provider())

match.fill_into_edit.append(match.keyword + base::char16(' '));

// We only allow inlinable navsuggestions that were received before the