components/omnibox/browser/autocomplete_input_unittest.cc - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Unified Diff: components/omnibox/browser/autocomplete_input_unittest.cc

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed forced queries using '?'. Removed Ctrl-K preserving the user's keyword if they're already … Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_browsertest.cc ('K') | « components/omnibox/browser/autocomplete_input.cc ('k') | components/omnibox/browser/autocomplete_provider.h » ('j') | components/omnibox/browser/autocomplete_result.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/autocomplete_input_unittest.cc

diff --git a/components/omnibox/browser/autocomplete_input_unittest.cc b/components/omnibox/browser/autocomplete_input_unittest.cc

index cb8eba12da6a3558fcf791e912077eeeffbcc46e..9c9d5c44175a9f58b1f1525f7603b2450afa5d4d 100644

--- a/components/omnibox/browser/autocomplete_input_unittest.cc

+++ b/components/omnibox/browser/autocomplete_input_unittest.cc

@@ -25,11 +25,11 @@ TEST(AutocompleteInputTest, InputType) {

const metrics::OmniboxInputType::Type type;

} input_cases[] = {

{ base::string16(), metrics::OmniboxInputType::INVALID },

- { ASCIIToUTF16("?"), metrics::OmniboxInputType::FORCED_QUERY },

- { ASCIIToUTF16("?foo"), metrics::OmniboxInputType::FORCED_QUERY },

- { ASCIIToUTF16("?foo bar"), metrics::OmniboxInputType::FORCED_QUERY },

+ { ASCIIToUTF16("?"), metrics::OmniboxInputType::QUERY },

+ { ASCIIToUTF16("?foo"), metrics::OmniboxInputType::QUERY },

+ { ASCIIToUTF16("?foo bar"), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("?http://foo.com/bar"),

- metrics::OmniboxInputType::FORCED_QUERY },

+ metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("foo"), metrics::OmniboxInputType::UNKNOWN },

{ ASCIIToUTF16("localhost"), metrics::OmniboxInputType::URL },

{ ASCIIToUTF16("foo._"), metrics::OmniboxInputType::QUERY },

@@ -295,10 +295,10 @@ TEST(AutocompleteInputTest, InputTypeWithCursorPosition) {

{ ASCIIToUTF16(" foo bar "), 2, ASCIIToUTF16("foo bar "), 0 },

// forced query.

Peter Kasting 2016/04/13 02:52:16 Nit: Maybe "A leading '?' used to be a magic chara

Tom (Use chromium acct) 2016/04/13 23:37:40 Done.

- { ASCIIToUTF16("?foo bar"), 2, ASCIIToUTF16("foo bar"), 1 },

- { ASCIIToUTF16(" ?foo bar"), 4, ASCIIToUTF16("foo bar"), 1 },

- { ASCIIToUTF16("? foo bar"), 4, ASCIIToUTF16("foo bar"), 1 },

- { ASCIIToUTF16(" ? foo bar"), 6, ASCIIToUTF16("foo bar"), 1 },

+ { ASCIIToUTF16("?foo bar"), 2, ASCIIToUTF16("?foo bar"), 2 },

+ { ASCIIToUTF16(" ?foo bar"), 4, ASCIIToUTF16("?foo bar"), 2 },

+ { ASCIIToUTF16("? foo bar"), 4, ASCIIToUTF16("? foo bar"), 4 },

+ { ASCIIToUTF16(" ? foo bar"), 6, ASCIIToUTF16("? foo bar"), 4 },

};

for (size_t i = 0; i < arraysize(input_cases); ++i) {