Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

components/omnibox/browser/omnibox_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines helper functions shared by the various implementations
 // of OmniboxView.
 
 #include "components/omnibox/browser/omnibox_view.h"
 
 #include <utility>
@@ skipping 148 matching lines @@
 
 bool OmniboxView::IsIndicatingQueryRefinement() const {
   // The default implementation always returns false.  Mobile ports can override
   // this method and implement as needed.
   return false;
 }
 
 void OmniboxView::OnMatchOpened(AutocompleteMatch::Type match_type) {
 }
 
+void OmniboxView::GetTextState(OmniboxView::TextState& state) {
+  state.text = GetText();
+  state.keyword = model()->keyword();
+  state.is_keyword_selected = model()->is_keyword_selected();
+  GetSelectionBounds(&state.sel_start, &state.sel_end);
+}
+
+OmniboxEditModel::TextStateChange OmniboxView::GetTextStateChange(
+    const TextState& before,
+    const TextState& after) {
+  OmniboxEditModel::TextStateChange state_change;
+  state_change.old_text = &before.text;
+  state_change.new_text = &after.text;
+  state_change.new_sel_start = after.sel_start;
+  state_change.new_sel_end = after.sel_end;
+  const bool old_sel_empty = before.sel_start == before.sel_end;
+  const bool new_sel_empty = after.sel_start == after.sel_end;
+  const bool sel_same_ignoring_direction =
+      std::min(before.sel_start, before.sel_end) ==
+          std::min(after.sel_start, after.sel_end) &&
+      std::max(before.sel_start, before.sel_end) ==
+          std::max(after.sel_start, after.sel_end);
+  state_change.selection_differs =
+      !((old_sel_empty && new_sel_empty) || sel_same_ignoring_direction);

[Peter Kasting, 2016/06/04 02:17:18]

Nit: Distribute ! through

[Tom (Use chromium acct), 2016/06/04 20:39:09]

Done.

+  state_change.text_differs = before.text != after.text;
+  state_change.keyword_differs =
+      (after.is_keyword_selected != before.is_keyword_selected) ||
+      (after.is_keyword_selected && before.is_keyword_selected &&
+       after.keyword != before.keyword);
+
+  // When the user has deleted text, we don't allow inline autocomplete.  Make
+  // sure to not flag cases like selecting part of the text and then pasting
+  // (or typing) the prefix of that selection.  (We detect these by making
+  // sure the caret, which should be after any insertion, hasn't moved
+  // forward of the old selection start.)
+  state_change.just_deleted_text =
+      (before.text.length() > after.text.length()) &&
+      (before.sel_start <= std::min(before.sel_start, before.sel_end));
+
+  return state_change;
+}
+
 OmniboxView::OmniboxView(OmniboxEditController* controller,
                          std::unique_ptr<OmniboxClient> client)
     : controller_(controller) {
   // |client| can be null in tests.
   if (client) {
     model_.reset(new OmniboxEditModel(this, controller, std::move(client)));
   }
 }
 
 void OmniboxView::TextChanged() {
   EmphasizeURLComponents();
   if (model_.get())
     model_->OnChanged();
 }