Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: components/omnibox/browser/autocomplete_provider.h

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed forced queries using '?'. Removed Ctrl-K preserving the user's keyword if they're already … Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_PROVIDER_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_PROVIDER_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_PROVIDER_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_PROVIDER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 // HistoryURL (inexact match) | 900++ 85 // HistoryURL (inexact match) | 900++
86 // BookmarkProvider (prefix match in bookmark title) | 900+- 86 // BookmarkProvider (prefix match in bookmark title) | 900+-
87 // Search Primary Provider (navigational suggestion) | 800++ 87 // Search Primary Provider (navigational suggestion) | 800++
88 // Search Primary Provider (suggestion) | 600++ 88 // Search Primary Provider (suggestion) | 600++
89 // Keyword (inexact match) | 450 89 // Keyword (inexact match) | 450
90 // Search Secondary Provider (what you typed) | 250 90 // Search Secondary Provider (what you typed) | 250
91 // Search Secondary Provider (past query in history) | 200-- 91 // Search Secondary Provider (past query in history) | 200--
92 // Search Secondary Provider (navigational suggestion) | 150++ 92 // Search Secondary Provider (navigational suggestion) | 150++
93 // Search Secondary Provider (suggestion) | 100++ 93 // Search Secondary Provider (suggestion) | 100++
94 // 94 //
95 // FORCED_QUERY input type:
96 // --------------------------------------------------------------------|-----
97 // Search Primary Provider (past query in history within 2 days) | 1399**
98 // Search Primary Provider (what you typed) | 1300
99 // Search Primary Provider (past query in history older than 2 days) | 1050--
100 // Search Primary Provider (navigational suggestion) | 800++
101 // Search Primary Provider (suggestion) | 600++
102 //
103 // (A search keyword is a keyword with a replacement string; a bookmark keyword 95 // (A search keyword is a keyword with a replacement string; a bookmark keyword
104 // is a keyword with no replacement string, that is, a shortcut for a URL.) 96 // is a keyword with no replacement string, that is, a shortcut for a URL.)
105 // 97 //
106 // There are two possible providers for search suggestions. If the user has 98 // There are two possible providers for search suggestions. If the user has
107 // typed a keyword, then the primary provider is the keyword provider and the 99 // typed a keyword, then the primary provider is the keyword provider and the
108 // secondary provider is the default provider. If the user has not typed a 100 // secondary provider is the default provider. If the user has not typed a
109 // keyword, then the primary provider corresponds to the default provider. 101 // keyword, then the primary provider corresponds to the default provider.
110 // 102 //
111 // Search providers may supply relevance values along with their results to be 103 // Search providers may supply relevance values along with their results to be
112 // used in place of client-side calculated values. 104 // used in place of client-side calculated values.
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 ACMatches matches_; 246 ACMatches matches_;
255 bool done_; 247 bool done_;
256 248
257 Type type_; 249 Type type_;
258 250
259 private: 251 private:
260 DISALLOW_COPY_AND_ASSIGN(AutocompleteProvider); 252 DISALLOW_COPY_AND_ASSIGN(AutocompleteProvider);
261 }; 253 };
262 254
263 #endif // COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_PROVIDER_H_ 255 #endif // COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698