Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: net/http/transport_security_state.h

Issue 18554002: Distinguish STS observation times from PKP observation times. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Declarations close to use; add comment. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index ccbc53a087dce599fef077399374ca21efe2506f..c112c735a2195b7e63b99eccd3f85c82135f9de4 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -95,10 +95,16 @@ class NET_EXPORT TransportSecurityState
UpgradeMode upgrade_mode;
- // The absolute time (UTC) when this DomainState was first created.
+ // The absolute time (UTC) when the |upgrade_mode| was observed.
//
- // Static entries do not have a created time.
- base::Time created;
+ // TODO(palmer): Perhaps static entries should have an "observed" time.
+ base::Time sts_observed;
+
+ // The absolute time (UTC) when the |dynamic_spki_hashes| (and other
+ // |dynamic_*| state) were observed.
+ //
+ // TODO(palmer): Perhaps static entries should have an "observed" time.
+ base::Time pkp_observed;
Ryan Sleevi 2013/07/02 23:41:10 FWIW, should you also add these fields to net-inte
palmer 2013/07/08 22:48:16 I was debating it. Yeah I will if you think I shou
// The absolute time (UTC) when the |upgrade_mode|, if set to
// UPGRADE_ALWAYS, downgrades to UPGRADE_NEVER.

Powered by Google App Engine
This is Rietveld 408576698