Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: net/http/transport_security_state.h

Issue 18554002: Distinguish STS observation times from PKP observation times. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a TODO to clean up the JavaScript. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/transport_security_persister.cc ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index 97b4d7c1fc8f82eb69a0628731a582750c95849c..3511b6916f582db5d126c0968fe7e2980e61d813 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -95,10 +95,16 @@ class NET_EXPORT TransportSecurityState
UpgradeMode upgrade_mode;
- // The absolute time (UTC) when this DomainState was first created.
+ // The absolute time (UTC) when the |upgrade_mode| was observed.
//
- // Static entries do not have a created time.
- base::Time created;
+ // TODO(palmer): Perhaps static entries should have an "observed" time.
+ base::Time sts_observed;
+
+ // The absolute time (UTC) when the |dynamic_spki_hashes| (and other
+ // |dynamic_*| state) were observed.
+ //
+ // TODO(palmer): Perhaps static entries should have an "observed" time.
+ base::Time pkp_observed;
// The absolute time (UTC) when the |upgrade_mode|, if set to
// UPGRADE_ALWAYS, downgrades to UPGRADE_NEVER.
« no previous file with comments | « net/http/transport_security_persister.cc ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698