Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2989)

Unified Diff: chrome/browser/resources/net_internals/hsts_view.js

Issue 18554002: Distinguish STS observation times from PKP observation times. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a TODO to clean up the JavaScript. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/net_internals/net_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/net_internals/hsts_view.js
diff --git a/chrome/browser/resources/net_internals/hsts_view.js b/chrome/browser/resources/net_internals/hsts_view.js
index 663248dda1cbf3f3cc4d84b9cabf0f46374650c6..5ed13607ffc14ccf46f6b451ad14b5f43a86b9c5 100644
--- a/chrome/browser/resources/net_internals/hsts_view.js
+++ b/chrome/browser/resources/net_internals/hsts_view.js
@@ -118,6 +118,8 @@ var HSTSView = (function() {
var s = addNode(this.queryOutputDiv_, 'span');
s.innerHTML = '<b>Found</b>: mode: ';
+ // TODO(palmer): Combine these 2-line pairs into 1:
+ // addNodeWithText(this.queryOutputDiv_, 'tt', results.sts_observed);
var t = addNode(this.queryOutputDiv_, 'tt');
t.textContent = modeToString(result.mode);
@@ -131,6 +133,16 @@ var HSTSView = (function() {
t = addNode(this.queryOutputDiv_, 'tt');
t.textContent = result.pkp_subdomains;
+ addTextNode(this.queryOutputDiv_, ' sts_observed:');
+
+ t = addNode(this.queryOutputDiv_, 'tt');
+ t.textContent = result.sts_observed;
+
+ addTextNode(this.queryOutputDiv_, ' pkp_observed:');
+
+ t = addNode(this.queryOutputDiv_, 'tt');
+ t.textContent = result.pkp_observed;
+
addTextNode(this.queryOutputDiv_, ' domain:');
t = addNode(this.queryOutputDiv_, 'tt');
« no previous file with comments | « no previous file | chrome/browser/ui/webui/net_internals/net_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698