chrome/browser/ui/find_bar/find_bar_host_browsertest.cc - Issue 1855393007: MD Downloads: ensure the DOM is ready before trying to find-in-page on it

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 1855393007: MD Downloads: ensure the DOM is ready before trying to find-in-page on it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

index b33892eef18cfad094d8c186d1409bb1dff7ff42..fe613eba76f5394a32a835251bf851c63b948013 100644

--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

@@ -336,6 +336,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_SearchWithinSpecialURL) {

ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));

FlushHistoryService();

+ ASSERT_TRUE(content::ExecuteScript(web_contents, "Polymer.dom.flush();"));

dpapad 2016/04/07 00:59:55 Nit(optional): Perhaps adding a comment to the eff

Dan Beam 2016/04/07 01:02:35 well, it's named Polymer.dom.flush(), i.e. flush P

sky 2016/04/07 19:11:38 Actually, one question. Why isn't ui_test_utils::N

Dan Beam 2016/04/07 19:12:21 because the list is rendered after onload

Dan Beam 2016/04/07 19:29:54 onload calls chrome.send()[1][2], which does CallJ

EXPECT_EQ(1, FindInPageASCII(web_contents, download_url.spec(),

kFwd, kIgnoreCase, NULL));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »