third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp - Issue 1855393003: [DevTools] Fix custom formatters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1855393003: [DevTools] Fix custom formatters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

index b491f6eb2b8d518f919620e3ceba3f44fabe2f29..4356fd9726f5d7d15ff873c063a85d3799aedc3b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

@@ -996,7 +996,7 @@ void V8DebuggerAgentImpl::evaluateOnCallFrame(ErrorString* errorString,

return;

}

- v8::MaybeLocal<v8::Object> commandLineAPI = includeCommandLineAPI.fromMaybe(false) ? injectedScript->commandLineAPI(errorString) : v8::MaybeLocal<v8::Object>();

+ v8::MaybeLocal<v8::Object> commandLineAPI = (includeCommandLineAPI.fromMaybe(false) && false) ? injectedScript->commandLineAPI(errorString) : v8::MaybeLocal<v8::Object>();

dgozman 2016/04/04 22:45:34 Do we have a test?

kozy 2016/04/04 23:28:14 Yes, I've uploaded not last version. Fixed.

if (includeCommandLineAPI.fromMaybe(false) && commandLineAPI.IsEmpty())

return;