[DevTools] Fix custom formatters

[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a
Cr-Commit-Position: refs/heads/master@{#385383}

[kozy, 2016-04-04 22:14:53]

Dmitry, please take a look!

[dgozman, 2016-04-04 22:45:34]

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:999:
v8::MaybeLocal<v8::Object> commandLineAPI =
(includeCommandLineAPI.fromMaybe(false) && false) ?
injectedScript->commandLineAPI(errorString) : v8::MaybeLocal<v8::Object>();
Do we have a test?

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:391:
return name == "bindRemoteObject";
Let's instead move last bits of implementation to InjectedScriptSource and not
expose anything.

[dgozman, 2016-04-04 23:24:14]

lgtm

[kozy, 2016-04-04 23:28:14]

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:999:
v8::MaybeLocal<v8::Object> commandLineAPI =
(includeCommandLineAPI.fromMaybe(false) && false) ?
injectedScript->commandLineAPI(errorString) : v8::MaybeLocal<v8::Object>();
On 2016/04/04 22:45:34, dgozman wrote:
> Do we have a test?

Yes, I've uploaded not last version. Fixed.

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1855393003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:391:
return name == "bindRemoteObject";
On 2016/04/04 22:45:34, dgozman wrote:
> Let's instead move last bits of implementation to InjectedScriptSource and not
> expose anything.

Since it's regression, I'll land it first and then prepare CL with moving last
bits of implementation.

[kozy, 2016-04-04 23:28:17]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-04 23:28:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1855393003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-04 23:28:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855393003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855393003/20001

[commit-bot: I haz the power, 2016-04-04 23:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 23:40:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kozy, 2016-04-04 23:49:53]

Description was changed from

==========
[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org
==========

to

==========
[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-04-04 23:49:53]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-04-04 23:50:19]

Pavel, please take a look.
I need owner lgtm for
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp .

[pfeldman, 2016-04-06 01:31:01]

lgtm

[kozy, 2016-04-06 01:32:19]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-04-06 01:32:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855393003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855393003/20001

[commit-bot: I haz the power, 2016-04-06 01:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 01:36:51]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[kozy, 2016-04-06 01:49:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-06 01:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1855393003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-04-06 01:49:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855393003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855393003/40001

[commit-bot: I haz the power, 2016-04-06 01:53:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 01:53:26]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kozy, 2016-04-06 03:29:15]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-06 03:29:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1855393003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-04-06 03:29:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855393003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855393003/80001

[commit-bot: I haz the power, 2016-04-06 04:51:30]

Description was changed from

==========
[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-04-06 04:51:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-06 04:52:26]

Description was changed from

==========
[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Fix custom formatters

Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension.
Inject remote object API on function call instead function compilation.

BUG=599884
R=dgozman@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a
Cr-Commit-Position: refs/heads/master@{#385383}
==========

[commit-bot: I haz the power, 2016-04-06 04:52:27]

Patchset 5 (id:??) landed as
https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a
Cr-Commit-Position: refs/heads/master@{#385383}