Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: content/browser/frame_host/render_frame_message_filter.cc

Issue 1855383002: Add DumpWithoutCrashing to RenderFrameMessageFilter cookie kills (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doghouse_now
Patch Set: Use possibly_invalid_spec Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/child_process_security_policy_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_message_filter.cc
diff --git a/content/browser/frame_host/render_frame_message_filter.cc b/content/browser/frame_host/render_frame_message_filter.cc
index 98bd0fd5e3783c7150b678adff464706a4864953..d666c706f9b88fd96c2fab462c88ab012f075abe 100644
--- a/content/browser/frame_host/render_frame_message_filter.cc
+++ b/content/browser/frame_host/render_frame_message_filter.cc
@@ -5,6 +5,8 @@
#include "content/browser/frame_host/render_frame_message_filter.h"
#include "base/command_line.h"
+#include "base/debug/crash_logging.h"
+#include "base/debug/dump_without_crashing.h"
#include "base/macros.h"
#include "base/metrics/field_trial.h"
#include "base/strings/string_util.h"
@@ -249,6 +251,17 @@ void RenderFrameMessageFilter::OnSetCookie(int render_frame_id,
ChildProcessSecurityPolicyImpl* policy =
ChildProcessSecurityPolicyImpl::GetInstance();
if (!policy->CanAccessDataForOrigin(render_process_id_, url)) {
+ {
+ // TODO(nick): Remove this once we understand http://crbug.com/600441
+ auto origin_lock = policy->GetOriginLockCrashKey(render_process_id_);
+ base::debug::ScopedCrashKey("setcookies_url",
+ url.possibly_invalid_spec());
+ base::debug::ScopedCrashKey(
+ "setcookies_first_party",
+ first_party_for_cookies.possibly_invalid_spec());
+ base::debug::DumpWithoutCrashing();
+ }
+
bad_message::ReceivedBadMessage(this,
bad_message::RFMF_SET_COOKIE_BAD_ORIGIN);
return;
« no previous file with comments | « content/browser/child_process_security_policy_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698