Add DumpWithoutCrashing to RenderFrameMessageFilter cookie kills

Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN and RFMF_GET_COOKIES_BAD_ORIGIN
renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/0e6e9faae9e11de8684440b128e75569b98c7553
Cr-Commit-Position: refs/heads/master@{#391396}

[ncarter (slow), 2016-04-04 19:05:36]

Description was changed from

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
==========

to

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-04-04 19:07:22]

Description was changed from

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-04-04 21:38:59]

nick@chromium.org changed reviewers:
+ avi@chromium.org

[ncarter (slow), 2016-04-04 21:38:59]

Hi avi, please take a look

[Avi (use Gerrit), 2016-04-05 01:41:24]

:(

https://codereview.chromium.org/1855383002/diff/40001/content/browser/child_p...
File content/browser/child_process_security_policy_impl.cc (right):

https://codereview.chromium.org/1855383002/diff/40001/content/browser/child_p...
content/browser/child_process_security_policy_impl.cc:837: "policy_origin_lock",
state == security_state_.end()
The key constant in the crash keys file is "security_origin_lock", not
"policy_origin_lock".

[ncarter (slow), 2016-04-05 18:35:52]

On 2016/04/05 01:41:24, Avi wrote:
> :(
> 
>
https://codereview.chromium.org/1855383002/diff/40001/content/browser/child_p...
> File content/browser/child_process_security_policy_impl.cc (right):
> 
>
https://codereview.chromium.org/1855383002/diff/40001/content/browser/child_p...
> content/browser/child_process_security_policy_impl.cc:837:
"policy_origin_lock",
> state == security_state_.end()
> The key constant in the crash keys file is "security_origin_lock", not
> "policy_origin_lock".

Whoops & good catch. I'm actually putting this CL on hold, since we have an idea
what might be happening (use enough extensions and we'll start sharing
processes!)

[ncarter (slow), 2016-05-03 00:16:01]

I'm reviving this patch. We fixed 90% of the kills, but we still don't
understand this 10%.

The plan is to revert this after a couple days.

https://codereview.chromium.org/1855383002/diff/40001/content/browser/child_p...
File content/browser/child_process_security_policy_impl.cc (right):

https://codereview.chromium.org/1855383002/diff/40001/content/browser/child_p...
content/browser/child_process_security_policy_impl.cc:837: "policy_origin_lock",
state == security_state_.end()
On 2016/04/05 01:41:23, Avi wrote:
> The key constant in the crash keys file is "security_origin_lock", not
> "policy_origin_lock".

Done. Good catch, thanks!

[Avi (use Gerrit), 2016-05-03 01:45:28]

lgtm

[Charlie Reis, 2016-05-03 17:33:33]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2016-05-03 17:33:34]

[Drive-by]

https://codereview.chromium.org/1855383002/diff/80001/content/browser/frame_h...
File content/browser/frame_host/render_frame_message_filter.cc (right):

https://codereview.chromium.org/1855383002/diff/80001/content/browser/frame_h...
content/browser/frame_host/render_frame_message_filter.cc:299:
bad_message::RFMF_GET_COOKIES_BAD_ORIGIN);
Isn't this the more frequent kill?  Maybe we should add the crash key on both.

[ncarter (slow), 2016-05-03 18:49:46]

Description was changed from

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN and RFMF_GET_COOKIES_BAD_ORIGIN
renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-05-03 18:50:33]

nick@chromium.org changed reviewers:
+ rsesek@chromium.org

[ncarter (slow), 2016-05-03 18:50:34]

Done.

+rsesek for crash_keys.cc

https://codereview.chromium.org/1855383002/diff/80001/content/browser/frame_h...
File content/browser/frame_host/render_frame_message_filter.cc (right):

https://codereview.chromium.org/1855383002/diff/80001/content/browser/frame_h...
content/browser/frame_host/render_frame_message_filter.cc:299:
bad_message::RFMF_GET_COOKIES_BAD_ORIGIN);
On 2016/05/03 17:33:34, Charlie Reis wrote:
> Isn't this the more frequent kill?  Maybe we should add the crash key on both.

Done.

[Robert Sesek, 2016-05-03 21:54:32]

lgtm

[Charlie Reis, 2016-05-03 22:05:47]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-05-03 22:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1855383002/#ps100001
(title: "Add second dump site.")

[commit-bot: I haz the power, 2016-05-03 22:06:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855383002/100001

[Robert Sesek, 2016-05-03 22:07:08]

FYI you're racing https://codereview.chromium.org/1925993004/ which will require
adding the key in a second place.

[commit-bot: I haz the power, 2016-05-03 23:34:23]

Description was changed from

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN and RFMF_GET_COOKIES_BAD_ORIGIN
renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN and RFMF_GET_COOKIES_BAD_ORIGIN
renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-05-03 23:34:25]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-03 23:35:27]

Description was changed from

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN and RFMF_GET_COOKIES_BAD_ORIGIN
renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add DumpWithoutCrashing and crash keys to get more context
for RFMF_SET_COOKIE_BAD_ORIGIN and RFMF_GET_COOKIES_BAD_ORIGIN
renderer kills.

This is all temporary code, which will be reverted after we understand
the issue.

BUG=600441
TEST=RenderFrameMessageFilterBrowserTest.CrossSiteCookieSecurityEnforcement
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/0e6e9faae9e11de8684440b128e75569b98c7553
Cr-Commit-Position: refs/heads/master@{#391396}
==========

[commit-bot: I haz the power, 2016-05-03 23:35:28]

Patchset 6 (id:??) landed as
https://crrev.com/0e6e9faae9e11de8684440b128e75569b98c7553
Cr-Commit-Position: refs/heads/master@{#391396}