[libfuzzer] update Efficient Fuzzer Guide and small fixes to documentation.

[libfuzzer] update Efficient Fuzzer Guide and small fixes to documentation.

R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org
BUG=595751
Committed: https://crrev.com/27ea9c23e8fb3f8c98a88e7e1c6e3d63e398ecb1
Cr-Commit-Position: refs/heads/master@{#385857}

[Oliver Chang, 2016-04-06 17:13:44]

lgtm

https://codereview.chromium.org/1855373008/diff/1/testing/libfuzzer/efficient...
File testing/libfuzzer/efficient_fuzzer.md (right):

https://codereview.chromium.org/1855373008/diff/1/testing/libfuzzer/efficient...
testing/libfuzzer/efficient_fuzzer.md:35: Avoid allocation of dynamic memory
whereever is possible. Instrumentation works
nit: s/whereever/wherever/
nit: no need for the "is"

[mmoroz, 2016-04-06 17:19:21]

Thanks!

https://codereview.chromium.org/1855373008/diff/1/testing/libfuzzer/efficient...
File testing/libfuzzer/efficient_fuzzer.md (right):

https://codereview.chromium.org/1855373008/diff/1/testing/libfuzzer/efficient...
testing/libfuzzer/efficient_fuzzer.md:35: Avoid allocation of dynamic memory
whereever is possible. Instrumentation works
On 2016/04/06 17:13:44, Oliver Chang wrote:
> nit: s/whereever/wherever/
> nit: no need for the "is"

Done.

[aarya, 2016-04-06 17:26:06]

aarya@google.com changed reviewers:
+ aarya@google.com, kcc@chromium.org

[aarya, 2016-04-06 17:26:07]

lgtm with nits. lets try to use sections whereever possible.

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
File testing/libfuzzer/efficient_fuzzer.md (right):

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
testing/libfuzzer/efficient_fuzzer.md:35: Avoid allocation of dynamic memory
wherever possible. Instrumentation works
YOu should name these two lines into a section like "Memory Allocation" or
"Memory Usage".

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
testing/libfuzzer/efficient_fuzzer.md:38: Experiment with different values of
`-max_len` parameter. This parameter often
Lines 38051 should be in a "Maximum Testcase Length" or "Testcase Size" or some
thing like that section.

[aizatsky, 2016-04-06 18:29:16]

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
File testing/libfuzzer/efficient_fuzzer.md (right):

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
testing/libfuzzer/efficient_fuzzer.md:35: Avoid allocation of dynamic memory
wherever possible. Instrumentation works
On 2016/04/06 17:26:07, aarya wrote:
> YOu should name these two lines into a section like "Memory Allocation" or
> "Memory Usage".

Agree. Plus I think it should be moved later in the document.

[mmoroz, 2016-04-07 13:35:06]

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
File testing/libfuzzer/efficient_fuzzer.md (right):

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
testing/libfuzzer/efficient_fuzzer.md:35: Avoid allocation of dynamic memory
wherever possible. Instrumentation works
On 2016/04/06 17:26:07, aarya wrote:
> YOu should name these two lines into a section like "Memory Allocation" or
> "Memory Usage".

Done.

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
testing/libfuzzer/efficient_fuzzer.md:35: Avoid allocation of dynamic memory
wherever possible. Instrumentation works
On 2016/04/06 18:29:16, aizatsky wrote:
> On 2016/04/06 17:26:07, aarya wrote:
> > YOu should name these two lines into a section like "Memory Allocation" or
> > "Memory Usage".
> 
> Agree. Plus I think it should be moved later in the document. 

Done.

https://codereview.chromium.org/1855373008/diff/20001/testing/libfuzzer/effic...
testing/libfuzzer/efficient_fuzzer.md:38: Experiment with different values of
`-max_len` parameter. This parameter often
On 2016/04/06 17:26:07, aarya wrote:
> Lines 38051 should be in a "Maximum Testcase Length" or "Testcase Size" or
some
> thing like that section.

Done.

[inferno, 2016-04-07 14:24:55]

lgtm

[aizatsky, 2016-04-07 20:31:50]

The CQ bit was checked by aizatsky@chromium.org

[aizatsky, 2016-04-07 20:31:50]

lgtm

[aizatsky, 2016-04-07 20:31:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
aarya@google.com
Link to the patchset: https://codereview.chromium.org/1855373008/#ps40001
(title: "Address comments: more sections and small reordering of them.")

[commit-bot: I haz the power, 2016-04-07 20:32:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855373008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855373008/40001

[commit-bot: I haz the power, 2016-04-07 21:17:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 21:29:36]

Description was changed from

==========
[libfuzzer] update Efficient Fuzzer Guide and small fixes to documentation.

R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org
BUG=595751
==========

to

==========
[libfuzzer] update Efficient Fuzzer Guide and small fixes to documentation.

R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org
BUG=595751

Committed: https://crrev.com/27ea9c23e8fb3f8c98a88e7e1c6e3d63e398ecb1
Cr-Commit-Position: refs/heads/master@{#385857}
==========

[commit-bot: I haz the power, 2016-04-07 21:29:38]

Patchset 3 (id:??) landed as
https://crrev.com/27ea9c23e8fb3f8c98a88e7e1c6e3d63e398ecb1
Cr-Commit-Position: refs/heads/master@{#385857}