Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1855373004: Rework Pixel.2DCanvasWebGL to be less than 400px wide. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rework Pixel.2DCanvasWebGL to be less than 400px wide. The test was experiencing the error "Invalid dimensions" on some Android devices. It's probably because the test was trying to do a screen capture wider than the dimensions of the phone. BUG=598510 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/71f45e21cf7f65aa80389531cdd7c9bfc87f0739 Cr-Commit-Position: refs/heads/master@{#385508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M content/test/data/gpu/pixel_canvas2d_webgl.html View 2 chunks +4 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855373004/1
4 years, 8 months ago (2016-04-04 23:21:47 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/682)
4 years, 8 months ago (2016-04-05 00:15:38 UTC) #5
erikchen
kbr: Please review.
4 years, 8 months ago (2016-04-05 17:26:14 UTC) #7
Ken Russell (switch to Gerrit)
lgtm
4 years, 8 months ago (2016-04-05 23:45:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855373004/1
4 years, 8 months ago (2016-04-05 23:48:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/206177)
4 years, 8 months ago (2016-04-06 06:41:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855373004/1
4 years, 8 months ago (2016-04-06 17:29:51 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 18:36:58 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 18:38:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71f45e21cf7f65aa80389531cdd7c9bfc87f0739
Cr-Commit-Position: refs/heads/master@{#385508}

Powered by Google App Engine
This is Rietveld 408576698