Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js

Issue 1855363002: DevTools: [ux regression] There is no way to clear console history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
index 0635313c49e422d57f8ae2c4c6b2f512482c7a1e..4ac69056be53cba8992d799c6b6cd4f60bf7a4d6 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
@@ -7,7 +7,7 @@ InspectorTest.evaluateInConsole = function(code, callback)
{
callback = InspectorTest.safeWrap(callback);
- var consoleView = WebInspector.ConsolePanel._view();
+ var consoleView = WebInspector.ConsoleView.instance();
consoleView.visible = true;
consoleView._prompt.setText(code);
var event = document.createEvent("KeyboardEvent");
@@ -68,7 +68,7 @@ InspectorTest.disableConsoleViewport = function()
InspectorTest.fixConsoleViewportDimensions = function(width, height)
{
- var viewport = WebInspector.ConsolePanel._view()._viewport;
+ var viewport = WebInspector.ConsoleView.instance()._viewport;
viewport.element.style.width = width + "px";
viewport.element.style.height = height + "px";
viewport.element.style.position = "absolute";
@@ -77,7 +77,7 @@ InspectorTest.fixConsoleViewportDimensions = function(width, height)
InspectorTest.consoleMessagesCount = function()
{
- var consoleView = WebInspector.ConsolePanel._view();
+ var consoleView = WebInspector.ConsoleView.instance();
return consoleView._consoleMessages.length;
}
@@ -91,7 +91,7 @@ InspectorTest.dumpConsoleMessagesIntoArray = function(printOriginatingCommand, d
formatter = formatter || InspectorTest.prepareConsoleMessageText;
var result = [];
InspectorTest.disableConsoleViewport();
- var consoleView = WebInspector.ConsolePanel._view();
+ var consoleView = WebInspector.ConsoleView.instance();
if (consoleView._needsFullUpdate)
consoleView._updateMessageList();
var viewMessages = consoleView._visibleViewMessages;
@@ -155,7 +155,7 @@ InspectorTest.dumpConsoleMessagesIgnoreErrorStackFrames = function(printOriginat
InspectorTest.dumpConsoleTableMessage = function(viewMessage, forceInvalidate, results)
{
if (forceInvalidate)
- WebInspector.ConsolePanel._view()._viewport.invalidate();
+ WebInspector.ConsoleView.instance()._viewport.invalidate();
var table = viewMessage.contentElement();
var headers = table.querySelectorAll("th > div:first-child");
if (!headers.length)
@@ -194,7 +194,7 @@ InspectorTest.dumpConsoleTableMessage = function(viewMessage, forceInvalidate, r
InspectorTest.dumpConsoleMessagesWithStyles = function(sortMessages)
{
var result = [];
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
for (var i = 0; i < messageViews.length; ++i) {
var element = messageViews[i].contentElement();
var messageText = InspectorTest.prepareConsoleMessageText(element)
@@ -207,7 +207,7 @@ InspectorTest.dumpConsoleMessagesWithStyles = function(sortMessages)
InspectorTest.dumpConsoleMessagesWithClasses = function(sortMessages) {
var result = [];
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
for (var i = 0; i < messageViews.length; ++i) {
var element = messageViews[i].contentElement();
var messageText = InspectorTest.prepareConsoleMessageText(element);
@@ -221,7 +221,7 @@ InspectorTest.dumpConsoleMessagesWithClasses = function(sortMessages) {
InspectorTest.dumpConsoleClassesBrief = function()
{
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
for (var i = 0; i < messageViews.length; ++i)
InspectorTest.addResult(messageViews[i].toMessageElement().className);
}
@@ -236,7 +236,7 @@ InspectorTest.dumpConsoleCounters = function()
InspectorTest.expandConsoleMessages = function(callback, deepFilter, sectionFilter)
{
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
// Initiate round-trips to fetch necessary data for further rendering.
for (var i = 0; i < messageViews.length; ++i)
@@ -274,7 +274,7 @@ InspectorTest.expandConsoleMessages = function(callback, deepFilter, sectionFilt
InspectorTest.expandGettersInConsoleMessages = function(callback)
{
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
var properties = [];
var propertiesCount = 0;
InspectorTest.addSniffer(WebInspector.ObjectPropertyTreeElement.prototype, "_updateExpandable", propertyExpandableUpdated);
@@ -304,7 +304,7 @@ InspectorTest.expandGettersInConsoleMessages = function(callback)
InspectorTest.expandConsoleMessagesErrorParameters = function(callback)
{
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
// Initiate round-trips to fetch necessary data for further rendering.
for (var i = 0; i < messageViews.length; ++i)
messageViews[i].contentElement();
@@ -329,7 +329,7 @@ InspectorTest.expandConsoleMessagesErrorParameters = function(callback)
InspectorTest.waitForRemoteObjectsConsoleMessages = function(callback)
{
- var messages = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messages = WebInspector.ConsoleView.instance()._visibleViewMessages;
for (var i = 0; i < messages.length; ++i)
messages[i].toMessageElement();
InspectorTest.runAfterPendingDispatches(callback);
@@ -337,7 +337,7 @@ InspectorTest.waitForRemoteObjectsConsoleMessages = function(callback)
InspectorTest.checkConsoleMessagesDontHaveParameters = function()
{
- var messageViews = WebInspector.ConsolePanel._view()._visibleViewMessages;
+ var messageViews = WebInspector.ConsoleView.instance()._visibleViewMessages;
for (var i = 0; i < messageViews.length; ++i) {
var m = messageViews[i].consoleMessage();
InspectorTest.addResult("Message[" + i + "]:");
@@ -372,7 +372,7 @@ InspectorTest.waitUntilNthMessageReceived = function(count, callback)
InspectorTest.changeExecutionContext = function(namePrefix)
{
- var selector = WebInspector.ConsolePanel._view()._executionContextModel._selectElement;
+ var selector = WebInspector.ConsoleView.instance()._executionContextModel._selectElement;
var option = selector.firstChild;
while (option) {
if (option.textContent && option.textContent.startsWith(namePrefix))
@@ -384,12 +384,12 @@ InspectorTest.changeExecutionContext = function(namePrefix)
return;
}
option.selected = true;
- WebInspector.ConsolePanel._view()._executionContextModel._executionContextChanged();
+ WebInspector.ConsoleView.instance()._executionContextModel._executionContextChanged();
}
InspectorTest.waitForConsoleMessages = function(expectedCount, callback)
{
- var consoleView = WebInspector.ConsolePanel._view();
+ var consoleView = WebInspector.ConsoleView.instance();
checkAndReturn();
function checkAndReturn()

Powered by Google App Engine
This is Rietveld 408576698