Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 185533014: Remove Script::SetData and the script_data parameter from Script::(Compile|New). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/factory.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1324 matching lines...) Expand 10 before | Expand all | Expand 10 after
1335 1335
1336 void V8HeapExplorer::ExtractScriptReferences(int entry, Script* script) { 1336 void V8HeapExplorer::ExtractScriptReferences(int entry, Script* script) {
1337 HeapObject* obj = script; 1337 HeapObject* obj = script;
1338 SetInternalReference(obj, entry, 1338 SetInternalReference(obj, entry,
1339 "source", script->source(), 1339 "source", script->source(),
1340 Script::kSourceOffset); 1340 Script::kSourceOffset);
1341 SetInternalReference(obj, entry, 1341 SetInternalReference(obj, entry,
1342 "name", script->name(), 1342 "name", script->name(),
1343 Script::kNameOffset); 1343 Script::kNameOffset);
1344 SetInternalReference(obj, entry, 1344 SetInternalReference(obj, entry,
1345 "data", script->data(),
1346 Script::kDataOffset);
1347 SetInternalReference(obj, entry,
1348 "context_data", script->context_data(), 1345 "context_data", script->context_data(),
1349 Script::kContextOffset); 1346 Script::kContextOffset);
1350 TagObject(script->line_ends(), "(script line ends)"); 1347 TagObject(script->line_ends(), "(script line ends)");
1351 SetInternalReference(obj, entry, 1348 SetInternalReference(obj, entry,
1352 "line_ends", script->line_ends(), 1349 "line_ends", script->line_ends(),
1353 Script::kLineEndsOffset); 1350 Script::kLineEndsOffset);
1354 } 1351 }
1355 1352
1356 1353
1357 void V8HeapExplorer::ExtractAccessorPairReferences( 1354 void V8HeapExplorer::ExtractAccessorPairReferences(
(...skipping 1707 matching lines...) Expand 10 before | Expand all | Expand 10 after
3065 writer_->AddString("\"<dummy>\""); 3062 writer_->AddString("\"<dummy>\"");
3066 for (int i = 1; i < sorted_strings.length(); ++i) { 3063 for (int i = 1; i < sorted_strings.length(); ++i) {
3067 writer_->AddCharacter(','); 3064 writer_->AddCharacter(',');
3068 SerializeString(sorted_strings[i]); 3065 SerializeString(sorted_strings[i]);
3069 if (writer_->aborted()) return; 3066 if (writer_->aborted()) return;
3070 } 3067 }
3071 } 3068 }
3072 3069
3073 3070
3074 } } // namespace v8::internal 3071 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698