Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/factory.cc

Issue 185533014: Remove Script::SetData and the script_data parameter from Script::(Compile|New). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 heap->set_last_script_id(Smi::FromInt(id)); 693 heap->set_last_script_id(Smi::FromInt(id));
694 694
695 // Create and initialize script object. 695 // Create and initialize script object.
696 Handle<Foreign> wrapper = NewForeign(0, TENURED); 696 Handle<Foreign> wrapper = NewForeign(0, TENURED);
697 Handle<Script> script = Handle<Script>::cast(NewStruct(SCRIPT_TYPE)); 697 Handle<Script> script = Handle<Script>::cast(NewStruct(SCRIPT_TYPE));
698 script->set_source(*source); 698 script->set_source(*source);
699 script->set_name(heap->undefined_value()); 699 script->set_name(heap->undefined_value());
700 script->set_id(Smi::FromInt(id)); 700 script->set_id(Smi::FromInt(id));
701 script->set_line_offset(Smi::FromInt(0)); 701 script->set_line_offset(Smi::FromInt(0));
702 script->set_column_offset(Smi::FromInt(0)); 702 script->set_column_offset(Smi::FromInt(0));
703 script->set_data(heap->undefined_value());
704 script->set_context_data(heap->undefined_value()); 703 script->set_context_data(heap->undefined_value());
705 script->set_type(Smi::FromInt(Script::TYPE_NORMAL)); 704 script->set_type(Smi::FromInt(Script::TYPE_NORMAL));
706 script->set_wrapper(*wrapper); 705 script->set_wrapper(*wrapper);
707 script->set_line_ends(heap->undefined_value()); 706 script->set_line_ends(heap->undefined_value());
708 script->set_eval_from_shared(heap->undefined_value()); 707 script->set_eval_from_shared(heap->undefined_value());
709 script->set_eval_from_instructions_offset(Smi::FromInt(0)); 708 script->set_eval_from_instructions_offset(Smi::FromInt(0));
710 script->set_flags(Smi::FromInt(0)); 709 script->set_flags(Smi::FromInt(0));
711 710
712 return script; 711 return script;
713 } 712 }
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1990 return Handle<Object>::null(); 1989 return Handle<Object>::null();
1991 } 1990 }
1992 1991
1993 1992
1994 Handle<Object> Factory::ToBoolean(bool value) { 1993 Handle<Object> Factory::ToBoolean(bool value) {
1995 return value ? true_value() : false_value(); 1994 return value ? true_value() : false_value();
1996 } 1995 }
1997 1996
1998 1997
1999 } } // namespace v8::internal 1998 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698