Wrap deprecated sandbox functions in C++ class.

sandbox/mac/seatbelt.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SANDBOX_MAC_SEATBELT_H_
+#define SANDBOX_MAC_SEATBELT_H_
+
+#include <cstdint>
+
+#include "base/macros.h"
+#include "sandbox/sandbox_export.h"

[Nico, 2016/04/05 18:37:18]

Oh, this probably won't work, you probably want a separate _export.h file for
your new component. Else, if you include a sandbox header in this file some time
down the line, the SANDBOX_EXPORTS in there will mean that the new seatbelt
component will also export these sandbox files.

[Greg K, 2016/04/05 18:44:54]

sandbox/linux uses sandbox_export across all of its different targets, so is
there a reason it's not a problem there but a problem on OS X?

Thanks,

Greg

[Nico, 2016/04/05 18:46:35]

It's a problem there too.

(source_sets can share exports as long as they're all linked into the same
component() in the end. Several components() can't use the same _EXPORT macro.
sandbox/linux has at least two components() that use SANDBOX_EXPORT; that's
incorrect as well.)

+
+namespace sandbox {
+
+// This class exists because OS X deprecated the sandbox functions,
+// and did not supply replacements that are suitable for Chrome.
+// This class wraps the functions in deprecation warning supressions.
+class SANDBOX_EXPORT Seatbelt {
+ public:
+  static int Init(const char* profile, uint64_t flags, char** errorbuf);
+
+  static int InitWithParams(const char* profile,
+                            uint64_t flags,
+                            const char* const parameters[],
+                            char** errorbuf);
+
+  static void FreeError(char* errorbuf);
+
+ private:
+  Seatbelt();
+  DISALLOW_COPY_AND_ASSIGN(Seatbelt);
+};
+
+}  // sandbox
+
+#endif  // SANDBOX_MAC_SEATBELT_H_